Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated Headers Get Dropped #321

Open
bjsvedin opened this issue Apr 4, 2025 · 1 comment
Open

Repeated Headers Get Dropped #321

bjsvedin opened this issue Apr 4, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@bjsvedin
Copy link

bjsvedin commented Apr 4, 2025

Version:

V0.36.0

The Issue:

When you add multiple headers to a request with the same key, only the last one will make it into the request. Restfox does deal with the case insensitivity correctly, so even with multiple case values in the keys only the last one will be added to the request.

Steps to reproduce:

  • Create a request to any valid HTTP server
  • Add two headers with the same key "X-Custom-Header" and with distinct values
  • Send the request and view the log in the Timeline tab or the output in the Request tab.
  • You will find that only the second header will be shown is shown, and the server will only get the second one.

Expected Results:

Both header entries will show up as distinct headers in the request.

The HTTP standard does support multiple values under the same key, either as separate entries or a list of comma separated values.

@flawiddsouza flawiddsouza added the bug Something isn't working label Apr 7, 2025
@flawiddsouza
Copy link
Owner

My request implementation assumed that the headers would always be a unique key value pair. Looks like I was wrong. This might take a while to correct, as there's different request logic for each platform (web, electron, extension).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants