chore(github CI): add eslint (#184)

* chore(github CI): add eslint

* update eslintrc

* fix error

Co-authored-by: zhengqi zhang <[email protected]>

Author: 0xmountaintop

.eslintrc.js

@@ -15,5 +15,7 @@ module.exports = {
     '@typescript-eslint/explicit-function-return-type': 'off',
     '@typescript-eslint/no-explicit-any': 'off',
     '@typescript-eslint/explicit-module-boundary-types': 'off',
+    '@typescript-eslint/no-inferrable-types': 'off',
+    'prefer-const': 'off',
   },
 };

.github/workflows/lint.yaml

@@ -42,5 +42,5 @@ jobs:
       - name: Prettify js/ts code
         run: npx prettier --check "**/*.{js,ts}"
 
-      # - run: |
-      #     npx eslint .
+      - run: |
+          npx eslint .

test/global_state.ts

@@ -47,7 +47,7 @@ class GlobalState {
     orderLevels: number,
     accountLevels: number,
     nTx: number,
-    options: object = { enable_self_trade: false, verbose: false },
+    options: any = { enable_self_trade: false, verbose: false },
   ) {
     this.balanceLevels = balanceLevels;
     this.orderLevels = orderLevels;
@@ -64,8 +64,8 @@ class GlobalState {
     this.orderIdToPos = new Map();
     this.orderPosToId = new Map();
     this.accounts = new Map(); // map[account_id]acount_state
-    this.bufferedTxs = new Array();
-    this.bufferedBlocks = new Array();
+    this.bufferedTxs = [];
+    this.bufferedBlocks = [];
     this.nextOrderPositions = new Map();
     this.options = options;
     this.nTx = nTx;

test/massive.ts

@@ -63,7 +63,7 @@ function initTestCase(nTxsn, balanceLevels, orderLevels, accountLevels) {
 
   /// start txs
 
-  for (var i = 0; i < nTxs; i++) {
+  for (let i = 0; i < nTxs; i++) {
     let spotTradeTx = {
       order1AccountID: accountID1,
       order2AccountID: accountID2,

test/testcases/block.ts

@@ -168,7 +168,7 @@ function initBlockTestCase() {
   };
   state.SpotTrade(spotTradeTx);
 
-  for (var i = state.bufferedTxs.length; i < nTxs; i++) {
+  for (let i = state.bufferedTxs.length; i < nTxs; i++) {
     state.Nop();
   }
 
@@ -182,7 +182,7 @@ function initEmptyBlockTestCase(): L2Block {
   let state = new GlobalState(balanceLevels, orderLevels, accountLevels, nTxs);
   // we need to have at least 1 account
   state.createNewAccount();
-  for (var i = 0; i < nTxs; i++) {
+  for (let i = 0; i < nTxs; i++) {
     state.Nop();
   }
   let block = state.forgeAllL2Blocks()[0];

test/testcases/encode_txdata.ts

@@ -111,7 +111,7 @@ function mockBigDepositToTx(): Array<bigint> {
 const tokenLevels = 6;
 const accountLevels = 2;
 
-function genOutput(payload: Array<bigint>): Object {
+function genOutput(payload: Array<bigint>): any {
   const hasher = new DA_Hasher(accountLevels, tokenLevels);
   hasher.encodeRawPayload(payload);
   return {

test/testcases/interface.ts

@@ -3,7 +3,7 @@ interface TestComponent {
   main: string;
 }
 interface SimpleTest {
-  getTestData(): Array<{ name: string; input: object; output?: object }>;
+  getTestData(): Array<{ name: string; input: any; output?: any }>;
   getComponent(): TestComponent;
 }
 

tools/inspect_l2_block.ts

@@ -1,12 +1,12 @@
-var fs = require('fs');
+const fs = require('fs');
 import { TxLength, TxDetailIdx } from '../test/codec/tx_data';
 import { TxType } from '../test/common/tx';
 function main() {
-  var obj = JSON.parse(fs.readFileSync(process.argv[2], 'utf8'));
+  let obj = JSON.parse(fs.readFileSync(process.argv[2], 'utf8'));
   for (let i = 0; i < obj.txsType.length; i++) {
     console.log('Tx', i);
     console.log('type:', TxType[obj.txsType[i]]);
-    for (var enumStr of Object.values(TxDetailIdx)) {
+    for (let enumStr of Object.values(TxDetailIdx)) {
       if (typeof enumStr == 'string') {
         const enumIdx = TxDetailIdx[enumStr];
         const value = obj.encodedTxs[i][enumIdx];