We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order id is like nonce, always incremental. User signed this id.
Meanwhile trade circuit uses idx of order merkle tree to fetch the order info then check trade price/amount against order info.
They are not same thing. After decoupling these two items, we can implement this #104
These are the only valid transition methods:
id
The above two can be combined if we assume order_id:0 means empty order, real order starts with order id 1.
The text was updated successfully, but these errors were encountered:
big refactor: #126 (#139)
93102fc
lispc
No branches or pull requests
decouple order id and merkle tree idx
Order id is like nonce, always incremental. User signed this id.
Meanwhile trade circuit uses idx of order merkle tree to fetch the order info then check trade price/amount against order info.
They are not same thing. After decoupling these two items, we can implement this #104
rewrite the order state transition login
These are the only valid transition methods:
id
is newer.The above two can be combined if we assume order_id:0 means empty order, real order starts with order id 1.
The text was updated successfully, but these errors were encountered: