Skip to content

Add Windows support #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
parthsane opened this issue Nov 14, 2019 · 1 comment
Closed

Add Windows support #84

parthsane opened this issue Nov 14, 2019 · 1 comment

Comments

@parthsane
Copy link

Windows support is blocked on #5

after bindgen is updated:
TODO:

  1. use alloca in rust_printf.c
  2. disable multithreading, pthreads, zlib support
mcr pushed a commit to mcr/rust-mbedtls that referenced this issue Aug 10, 2023
PoolKey calls unwrap() on an option that can be None. Specifically, the
local variable `port` can be None when PoolKey is constructed with a Url
whose scheme is unrecognized in url.port_or_known_default().

To fix that, make port an Option. Also, make scheme part of the PoolKey.
This prevents, for instance, a stream opened for `https://example.com:9999`
being reused on a request for `http://example.com:9999`.

Remove the test-only pool.get() accessor. This was used in only one test,
agent_pool in range.rs. This seemed like it was testing the agent more
than it was testing ranges, so I moved it to agent.rs and edited to
remove the range-testing parts.

Also, reject unrecognized URLs earlier in connect_socket so they don't
reach try_get_connection.
@Taowyoo
Copy link
Collaborator

Taowyoo commented Sep 14, 2023

Done by #235
Now 0.9.3 or master rust-mbedtls is able to be compiled with target x86_64-pc-windows-msvc on stable

@Taowyoo Taowyoo closed this as completed Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants