Skip to content

Commit 399b3f5

Browse files
authored
v1 Candidate (#8)
* Bump devDeps, microbundle, use TS strict mode * Prettier all the things * Tune eslint to speak Typescript * Install husky * Fix fallbackUtils errors * Accept 'sizes', refactor LazyImageFull Breaking: LazyImageFull now only takes children as a function, not render. Improvement: Simplified LazyImageFull code in a bunch of places, such that it only concerns itself with the observing and loading. * Pass ref, use prop collection * Refactor props collection * Factor out initialState, consolidate ImageProps * Update usage instructions * Update stories * Bump react-intersection-observer * Update stories, handle refs Refs make things more annoying, but at least there is no wrapper now. * Add experimental img.decode() support * 1.0.0-rc.1 * 1.0.0-rc.2
1 parent b79b808 commit 399b3f5

15 files changed

+5604
-3558
lines changed

.eslintrc

+16
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
{
2+
"parser": "typescript-eslint-parser",
3+
"plugins": [
4+
"jsx-a11y"
5+
],
6+
"extends": [
7+
"plugin:jsx-a11y/recommended"
8+
],
9+
"parserOptions": {
10+
"ecmaVersion": 6,
11+
"sourceType": "module",
12+
"ecmaFeatures": {
13+
"jsx": true
14+
}
15+
}
16+
}

.prettier

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
{
2+
"printWidth": 80,
3+
"bracketSpacing": false,
4+
"singleQuote": true,
5+
"trailingComma": "es5"
6+
}

README.md

+92-95
Large diffs are not rendered by default.

ROADMAP.md

+15-2
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,30 @@
11
# Always
2+
23
- Docs improvements! See [`FEEDBACK.md`](./FEEDBACK.md) for specific points.
34
- Loading patterns and auxiliary component examples
45

56
# v1
6-
- [ ] Elicit feedback and use cases for the public API
7-
- [ ] Investigate container `<div>`
7+
8+
- [x] Upgrade devDeps
9+
- [x] Upgrade microbundle
10+
- [x] Check --external all consequence
11+
- [x] Upgrade react-intersection-observer
12+
- [x] Pass Ref
13+
- [x] Prop collection
14+
- [x] Split out renderXYZ components
15+
- [x] Refactor props
16+
- [x] Elicit feedback and use cases for the public API
17+
- [~] Investigate container `<div>`
818
- [ ] Solidify `<noscript>` fallback
19+
- [x] experimentalDecode
920

1021
# Investigate
22+
1123
- [ ] Auto sizes (if not handled already by browser behaviour)
1224
- [ ] cancel loading on componentWillUnmount
1325

1426
# Later
27+
1528
- [ ] abort loading if image leaves viewport and it has not loaded sufficiently
1629
- Likely a large change to how we do things
1730
- Possibly with using fetch and cancelling it

0 commit comments

Comments
 (0)