Information about bug

When creating a Quotation, Sales Order, or Sales Invoice that includes both a discount and a shipping rule, the discount is calculated twice. The trigger is the combination of the shipping rule and the discount. It does not matter whether the shipping rule sets the shipping cost to €0 or to €0.01. When both a shipping rule and a discount are selected, the discount is applied twice to the original gross price. See video for reproduction. Happens both in v14 and v15.

Impact

When a quotation is then created with the incorrect price, converted into a Sales Order, and finally into an Invoice, the invoice cannot be posted because the amount is incorrect. This results in having incorrect Quotations and Sales Orders in the system, and if not properly checked beforehand, the error is only detected during invoice creation.

We appreciate any insights or potential fixes for this issue.

Thank you!

Module

selling

Version

Version 14 Setup
Frappe version - v14.95.2
ERPNext version - v14.85.3

Version 15 Setup
Frappe version - v15.63.1
ERPNext version - v15.57.5

Installation method

Docker

Relevant log output / Stack trace / Full Error Message.