fix: app name pattern (OfficeDev#1283)

Author: jayzhang

samples/app-anonymous-users/nodejs/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: app-anonymous-users-${{TEAMSFX_ENV}}
+      name: app-anonymous-users${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile:

samples/app-cache-meetings/nodejs/teamsapp.local.yml

@@ -11,7 +11,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: app-cache-meetings-${{TEAMSFX_ENV}}
+      name: app-cache-meetings${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 

samples/app-checkin-location/nodejs/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: app-checkin-location-${{TEAMSFX_ENV}}
+      name: app-checkin-location${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 

samples/app-complete-auth/nodejs/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: app-complete-auth-${{TEAMSFX_ENV}}
+      name: app-complete-auth${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile:

samples/app-complete-sample/nodejs/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: app-complete-sample-${{TEAMSFX_ENV}}
+      name: app-complete-sample${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile:

samples/app-hello-world/nodejs/env/.env.local

@@ -2,7 +2,7 @@
 
 # Built-in environment variables
 TEAMSFX_ENV=local
-
+APP_NAME_SUFFIX=local
 # Generated during provision, you can also add your own variables. If you're adding a secret value, add SECRET_ prefix to the name so Teams Toolkit can handle them properly
 BOT_ENDPOINT=
 BOT_DOMAIN=

samples/app-hello-world/nodejs/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: app-hello-world-${{TEAMSFX_ENV}}
+      name: app-hello-world${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile:

samples/app-installation-using-qr-code/nodejs/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: app-installation-using-qr-code-${{TEAMSFX_ENV}}
+      name: app-installation-using-qr-code${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile:

samples/app-link-unfurling-in-share-to-teams/nodejs/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: app-link-unfurling-in-share-to-teams-${{TEAMSFX_ENV}}
+      name: app-link-unfurling-in-share-to-teams${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 

samples/app-localization/nodejs/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: app-localization-${{TEAMSFX_ENV}}
+      name: app-localization${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 

samples/app-sso/nodejs/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: app-sso-${{TEAMSFX_ENV}}
+      name: app-sso${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile:

samples/bot-adaptive-card-actions/csharp/TeamsApp/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: bot-adaptive-card-actions-${{TEAMSFX_ENV}}
+      name: bot-adaptive-card-actions${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 

samples/bot-adaptive-card-actions/nodejs/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: bot-adaptive-card-actions-${{TEAMSFX_ENV}}
+      name: bot-adaptive-card-actions${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 

samples/bot-ai-enterprise-search/nodejs/appManifest/manifest.json

@@ -15,7 +15,7 @@
         "outline": "outline.png"
     },
     "name": {
-        "short": "AI-EnterpriseSearch-${{TEAMSFX_ENV}}",
+        "short": "AI-EnterpriseSearch${{APP_NAME_SUFFIX}}",
         "full": "full name for AI-EnterpriseSearch"
     },
     "description": {

samples/bot-ai-enterprise-search/nodejs/env/.env.dev

@@ -2,7 +2,7 @@
 
 # Built-in environment variables
 TEAMSFX_ENV=dev
-
+APP_NAME_SUFFIX=dev
 # Updating AZURE_SUBSCRIPTION_ID or AZURE_RESOURCE_GROUP_NAME after provision may also require an update to RESOURCE_SUFFIX, because some services require a globally unique name across subscriptions/resource groups.
 AZURE_SUBSCRIPTION_ID=
 AZURE_RESOURCE_GROUP_NAME=

samples/bot-ai-enterprise-search/nodejs/teamsapp.local.yml

@@ -11,7 +11,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: AI-EnterpriseSearch-${{TEAMSFX_ENV}}
+      name: AI-EnterpriseSearch${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 
@@ -21,7 +21,7 @@ provision:
   - uses: botAadApp/create
     with:
       # The Azure Active Directory application's display name
-      name: AI-EnterpriseSearch-${{TEAMSFX_ENV}}
+      name: AI-EnterpriseSearch${{APP_NAME_SUFFIX}}
     writeToEnvironmentFile:
       # The Azure Active Directory application's client id created for bot.
       botId: BOT_ID

samples/bot-ai-enterprise-search/nodejs/teamsapp.yml

@@ -14,7 +14,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: AI-EnterpriseSearch-${{TEAMSFX_ENV}}
+      name: AI-EnterpriseSearch${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile:
@@ -24,7 +24,7 @@ provision:
   - uses: botAadApp/create
     with:
       # The Azure Active Directory application's display name
-      name: AI-EnterpriseSearch-${{TEAMSFX_ENV}}
+      name: AI-EnterpriseSearch${{APP_NAME_SUFFIX}}
     writeToEnvironmentFile:
       # The Azure Active Directory application's client id created for bot.
       botId: BOT_ID

samples/bot-all-cards/nodejs/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: bot-all-cards-${{TEAMSFX_ENV}}
+      name: bot-all-cards${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile:

samples/bot-archive-groupchat-messages/csharp/FetchGroupChatMessages/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: bot-archive-groupchat-messages-${{TEAMSFX_ENV}}
+      name: bot-archive-groupchat-messages${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 

samples/bot-archive-groupchat-messages/nodejs/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: bot-archive-groupchat-messages-${{TEAMSFX_ENV}}
+      name: bot-archive-groupchat-messages${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile:

samples/bot-configuration-app-auth/nodejs/env/.env.dev

@@ -2,7 +2,7 @@
 
 # Built-in environment variables
 TEAMSFX_ENV=dev
-
+APP_NAME_SUFFIX=dev
 # Updating AZURE_SUBSCRIPTION_ID or AZURE_RESOURCE_GROUP_NAME after provision may also require an update to RESOURCE_SUFFIX, because some services require a globally unique name across subscriptions/resource groups.
 AZURE_SUBSCRIPTION_ID=
 AZURE_RESOURCE_GROUP_NAME=

samples/bot-configuration-app-auth/nodejs/teamsapp.local.yml

@@ -11,7 +11,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: nodejs-${{TEAMSFX_ENV}}
+      name: nodejs${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 
@@ -21,7 +21,7 @@ provision:
   - uses: botAadApp/create
     with:
       # The Azure Active Directory application's display name
-      name: nodejs-${{TEAMSFX_ENV}}
+      name: nodejs${{APP_NAME_SUFFIX}}
     writeToEnvironmentFile:
       # The Azure Active Directory application's client id created for bot.
       botId: BOT_ID

samples/bot-configuration-app-auth/nodejs/teamsapp.yml

@@ -14,7 +14,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: nodejs-${{TEAMSFX_ENV}}
+      name: nodejs${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile:
@@ -24,7 +24,7 @@ provision:
   - uses: botAadApp/create
     with:
       # The Azure Active Directory application's display name
-      name: nodejs-${{TEAMSFX_ENV}}
+      name: nodejs${{APP_NAME_SUFFIX}}
     writeToEnvironmentFile:
       # The Azure Active Directory application's client id created for bot.
       botId: BOT_ID

samples/bot-configuration-app/csharp/Bot configuration/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: bot-configuration-app-${{TEAMSFX_ENV}}
+      name: bot-configuration-app${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 

samples/bot-configuration-app/csharp/TeamsApp/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: bot-configuration-app-${{TEAMSFX_ENV}}
+      name: bot-configuration-app${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 

samples/bot-configuration-app/nodejs/env/.env.dev

@@ -2,7 +2,7 @@
 
 # Built-in environment variables
 TEAMSFX_ENV=dev
-
+APP_NAME_SUFFIX=dev
 # Updating AZURE_SUBSCRIPTION_ID or AZURE_RESOURCE_GROUP_NAME after provision may also require an update to RESOURCE_SUFFIX, because some services require a globally unique name across subscriptions/resource groups.
 AZURE_SUBSCRIPTION_ID=
 AZURE_RESOURCE_GROUP_NAME=

samples/bot-configuration-app/nodejs/teamsapp.local.yml

@@ -11,7 +11,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: nodejs-${{TEAMSFX_ENV}}
+      name: nodejs${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 
@@ -21,7 +21,7 @@ provision:
   - uses: botAadApp/create
     with:
       # The Azure Active Directory application's display name
-      name: nodejs-${{TEAMSFX_ENV}}
+      name: nodejs${{APP_NAME_SUFFIX}}
     writeToEnvironmentFile:
       # The Azure Active Directory application's client id created for bot.
       botId: BOT_ID

samples/bot-configuration-app/nodejs/teamsapp.yml

@@ -14,7 +14,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: nodejs-${{TEAMSFX_ENV}}
+      name: nodejs${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile:
@@ -24,7 +24,7 @@ provision:
   - uses: botAadApp/create
     with:
       # The Azure Active Directory application's display name
-      name: nodejs-${{TEAMSFX_ENV}}
+      name: nodejs${{APP_NAME_SUFFIX}}
     writeToEnvironmentFile:
       # The Azure Active Directory application's client id created for bot.
       botId: BOT_ID

samples/bot-conversation-quickstart/js/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: bot-conversation-quickstart-${{TEAMSFX_ENV}}
+      name: bot-conversation-quickstart${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 

samples/bot-conversation-sso-quickstart/csharp_dotnetcore/BotConversationSsoQuickstart/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: bot-conversation-sso-quickstart-${{TEAMSFX_ENV}}
+      name: bot-conversation-sso-quickstart${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 

samples/bot-conversation-sso-quickstart/csharp_dotnetcore/TeamsApp/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: bot-conversation-sso-quickstart-${{TEAMSFX_ENV}}
+      name: bot-conversation-sso-quickstart${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 

samples/bot-conversation-sso-quickstart/js/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: bot-conversation-sso-quickstart-${{TEAMSFX_ENV}}
+      name: bot-conversation-sso-quickstart${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile:

samples/bot-conversation/csharp/TeamsApp/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: bot-conversation-${{TEAMSFX_ENV}}
+      name: bot-conversation${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 

samples/bot-conversation/nodejs/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: bot-conversation-${{TEAMSFX_ENV}}
+      name: bot-conversation${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 

samples/bot-conversation/python/teamsapp.local.yml

@@ -25,7 +25,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: teamsConversationBot-${{TEAMSFX_ENV}}
+      name: teamsConversationBot${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 

samples/bot-daily-task-reminder/csharp/TeamsApp/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: bot-daily-task-reminder-${{TEAMSFX_ENV}}
+      name: bot-daily-task-reminder${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 

samples/bot-daily-task-reminder/nodejs/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: bot-daily-task-reminder-${{TEAMSFX_ENV}}
+      name: bot-daily-task-reminder${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: 

samples/bot-file-upload/csharp/TeamsApp/teamsapp.local.yml

@@ -24,7 +24,7 @@ provision:
   - uses: teamsApp/create
     with:
       # Teams app name
-      name: bot-file-upload-${{TEAMSFX_ENV}}
+      name: bot-file-upload${{APP_NAME_SUFFIX}}
     # Write the information of created resources into environment file for
     # the specified environment variable(s).
     writeToEnvironmentFile: