Skip to content

feat(curriculum): add polygon area calculator lab #59460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat(curriculum): add polygon area calculator lab #59460

wants to merge 8 commits into from
+907 −2

Conversation

zairahira
Copy link
Member

@zairahira zairahira commented Mar 27, 2025 •
edited
Loading

Checklist:

Closes freeCodeCamp/CurriculumExpansion#720

@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels Mar 27, 2025
@zairahira zairahira added full stack cert This label is for the new full stack certification and removed scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels Mar 27, 2025
@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels Mar 27, 2025
@zairahira zairahira marked this pull request as ready for review March 27, 2025 08:56
@zairahira zairahira requested a review from a team as a code owner March 27, 2025 08:56
@realamanvats

This comment was marked as off-topic.

Sign in to view
@jdwilkin4 jdwilkin4 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Mar 27, 2025
@zairahira @Ksound22
apply suggestion
4511c70 
Co-authored-by: Kolade Chris <[email protected]>
@moT01 moT01 removed the scope: i18n language translation/internationalization. Often combined with language type label label Apr 2, 2025
@moT01 moT01 self-assigned this Apr 3, 2025
moT01
moT01 requested changes Apr 3, 2025
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @zairahira 👍

I found a few minor things. Additionally, I think we should use the ID from the old project and add it to the mongo-ids.js file like we've done with other projects that we duplicate. What do you think? Make sure to change the filename as well if you do that.

@moT01 moT01 added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Apr 3, 2025
@github-actions github-actions bot added the scope: i18n language translation/internationalization. Often combined with language type label label Apr 4, 2025
@zairahira
Copy link
Member Author

Hi @moT01,
Thanks for the feedback.

I have updated the challenge ID as the lab is very similar to the original project.

@zairahira zairahira requested a review from moT01 April 4, 2025 09:52
@zairahira zairahira removed the status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP label Apr 4, 2025
@zairahira zairahira added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Apr 4, 2025
Dario-DC
Dario-DC reviewed Apr 16, 2025
View reviewed changes
...ges/english/25-front-end-development/lab-polygon-area-calculator/5e444147903586ffb414c94f.md
---
id: 5e444147903586ffb414c94f
title: Build a Polygon Area Calculator
challengeType: 23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
challengeType: 23
challengeType: 27

We have a new challenge type #59732

@Dario-DC
Copy link
Contributor

Dario-DC commented Apr 16, 2025 •
edited
Loading

We need to update the full-stack.json file as well @zairahira
Edit: just saw it's already done 👍

@ilenia-magoni
Copy link
Contributor

@Dario-DC see #59552

@moT01 moT01 added status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP and removed status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. labels Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dario-DC Dario-DC Dario-DC left review comments

@moT01 moT01 Awaiting requested review from moT01

@ilenia-magoni ilenia-magoni Awaiting requested review from ilenia-magoni

@Ksound22 Ksound22 Awaiting requested review from Ksound22

Requested changes must be addressed to merge this pull request.

Assignees

@moT01 moT01

Labels
full stack cert This label is for the new full stack certification platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting update To be applied to PR if a maintainer/reviewer has left a feedback and follow up is needed from OP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert the polygon area calculator into a lab and add it to main
7 participants
@zairahira @realamanvats @Dario-DC @ilenia-magoni @moT01 @Ksound22 @jdwilkin4