From b17d72ea5971f5081a43fdbbb7e70c6aa9e3d6ba Mon Sep 17 00:00:00 2001 From: c0d1ng_ma5ter Date: Thu, 27 Feb 2025 09:52:59 -0600 Subject: [PATCH 1/4] fix(UI): Clarify searchbar text --- config/i18n/locales/english/translations.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config/i18n/locales/english/translations.json b/config/i18n/locales/english/translations.json index c8600d910..6e4717d8c 100644 --- a/config/i18n/locales/english/translations.json +++ b/config/i18n/locales/english/translations.json @@ -8,8 +8,8 @@ "label": "Search", "accessible-name": "Submit your search query", "placeholder": { - "default": "Search our tutorials", - "numbered": "Search {{ roundedTotalRecords }}+ tutorials" + "default": "Search our news articles, tutorials and books", + "numbered": "Search {{ roundedTotalRecords }}+ news articles, tutorials and books" }, "see-results": "See all results for {{ searchQuery }}", "no-tutorials": "No tutorials found" From 5a43be43dcd7e354e9f8f8bbff0c2b9f668fa805 Mon Sep 17 00:00:00 2001 From: c0d1ng_ma5ter Date: Wed, 16 Apr 2025 18:02:22 +0000 Subject: [PATCH 2/4] Make the thing consistent with /learn --- .gitpod.yml | 11 +++++++++++ config/i18n/locales/english/translations.json | 2 +- src/_includes/assets/js/search-bar.js | 2 +- 3 files changed, 13 insertions(+), 2 deletions(-) create mode 100644 .gitpod.yml diff --git a/.gitpod.yml b/.gitpod.yml new file mode 100644 index 000000000..e43643f73 --- /dev/null +++ b/.gitpod.yml @@ -0,0 +1,11 @@ +# This configuration file was automatically generated by Gitpod. +# Please adjust to your needs (see https://www.gitpod.io/docs/introduction/learn-gitpod/gitpod-yaml) +# and commit this file to your remote git repository to share the goodness with others. + +# Learn more from ready-to-use templates: https://www.gitpod.io/docs/introduction/getting-started/quickstart + +tasks: + - init: npm install && npm run build + command: npm run start + + diff --git a/config/i18n/locales/english/translations.json b/config/i18n/locales/english/translations.json index 6e4717d8c..23475d911 100644 --- a/config/i18n/locales/english/translations.json +++ b/config/i18n/locales/english/translations.json @@ -12,7 +12,7 @@ "numbered": "Search {{ roundedTotalRecords }}+ news articles, tutorials and books" }, "see-results": "See all results for {{ searchQuery }}", - "no-tutorials": "No tutorials found" + "no-results": "No results found" }, "banner": { "default": "Learn to code — {{ <0> }}free 3,000-hour curriculum{{ }}", diff --git a/src/_includes/assets/js/search-bar.js b/src/_includes/assets/js/search-bar.js index 8a1a22e9d..788d50a68 100644 --- a/src/_includes/assets/js/search-bar.js +++ b/src/_includes/assets/js/search-bar.js @@ -51,7 +51,7 @@ document.addEventListener('DOMContentLoaded', () => {
- {% t 'search.no-tutorials' %} + {% t 'search.no-results' %}
From f3f51248e6df0555764361485788e3e9435a4753 Mon Sep 17 00:00:00 2001 From: c0d1ng_ma5ter Date: Thu, 17 Apr 2025 23:32:48 -0600 Subject: [PATCH 3/4] Delete a random gitpod file --- .gitpod.yml | 11 ----------- 1 file changed, 11 deletions(-) delete mode 100644 .gitpod.yml diff --git a/.gitpod.yml b/.gitpod.yml deleted file mode 100644 index e43643f73..000000000 --- a/.gitpod.yml +++ /dev/null @@ -1,11 +0,0 @@ -# This configuration file was automatically generated by Gitpod. -# Please adjust to your needs (see https://www.gitpod.io/docs/introduction/learn-gitpod/gitpod-yaml) -# and commit this file to your remote git repository to share the goodness with others. - -# Learn more from ready-to-use templates: https://www.gitpod.io/docs/introduction/getting-started/quickstart - -tasks: - - init: npm install && npm run build - command: npm run start - - From 3876f8e9bc79adee7faf906d4070057c8fe8f3f3 Mon Sep 17 00:00:00 2001 From: c0d1ng_ma5ter Date: Thu, 17 Apr 2025 23:33:53 -0600 Subject: [PATCH 4/4] Change the wording a bit --- config/i18n/locales/english/translations.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config/i18n/locales/english/translations.json b/config/i18n/locales/english/translations.json index 23475d911..81449ba21 100644 --- a/config/i18n/locales/english/translations.json +++ b/config/i18n/locales/english/translations.json @@ -8,8 +8,8 @@ "label": "Search", "accessible-name": "Submit your search query", "placeholder": { - "default": "Search our news articles, tutorials and books", - "numbered": "Search {{ roundedTotalRecords }}+ news articles, tutorials and books" + "default": "Search our news articles, tutorials, and books", + "numbered": "Search {{ roundedTotalRecords }}+ news articles, tutorials, and books" }, "see-results": "See all results for {{ searchQuery }}", "no-results": "No results found"