Skip to content

Commit 2b98ad6

Browse files
committed
Use only kw args when accessing es
1 parent 7ea76d2 commit 2b98ad6

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

tableschema_elasticsearch/storage.py

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ class Storage(object):
4242
"""
4343

4444
# Public
45-
4645
def __init__(self, es=None):
4746
# Use the passed `es` or create a new Elasticsearch instance
4847
self.__es = es if es is not None else Elasticsearch()
@@ -55,7 +54,7 @@ def __repr__(self):
5554

5655
@property
5756
def buckets(self):
58-
indexes = self.__es.indices.get_alias('*')
57+
indexes = self.__es.indices.get_alias(index='*')
5958
for index_name, index in indexes.items():
6059
for alias_name in index.get('aliases', {}).keys():
6160
yield alias_name
@@ -72,15 +71,15 @@ def create_index(self, bucket, index_settings=None):
7271
body = dict(
7372
settings=index_settings
7473
)
75-
self.__es.indices.create(index_name, body=body)
76-
self.__es.indices.put_alias(index_name, bucket)
74+
self.__es.indices.create(index=index_name, body=body)
75+
self.__es.indices.put_alias(index=index_name, name=bucket)
7776
return index_name
7877

7978
def put_mapping(self, bucket, descriptor, index_name, mapping_generator_cls):
8079
mapping = mappers.descriptor_to_mapping(
8180
descriptor, mapping_generator_cls=mapping_generator_cls
8281
)
83-
self.__es.indices.put_mapping(mapping, index=index_name)
82+
self.__es.indices.put_mapping(index=index_name, **mapping)
8483

8584
def generate_doc_id(self, row, primary_key):
8685
return '/'.join([str(row.get(k)) for k in primary_key])
@@ -108,7 +107,7 @@ def create(self, bucket, descriptor,
108107
"""
109108
existing_index_names = []
110109
if self.__es.indices.exists_alias(name=bucket):
111-
existing_index_names = self.__es.indices.get_alias(bucket)
110+
existing_index_names = self.__es.indices.get_alias(name=bucket)
112111
existing_index_names = sorted(existing_index_names.keys())
113112

114113
if len(existing_index_names) == 0 or always_recreate:
@@ -138,11 +137,11 @@ def create(self, bucket, descriptor,
138137
version_type='external'
139138
)
140139
)
141-
self.__es.reindex(reindex_body)
140+
self.__es.reindex(body=reindex_body)
142141
self.__es.indices.flush()
143142

144143
for existing_index_name in existing_index_names:
145-
self.__es.indices.delete(existing_index_name)
144+
self.__es.indices.delete(index=existing_index_name)
146145

147146
def delete(self, bucket=None):
148147
"""Delete index with mapping by schema.
@@ -153,10 +152,10 @@ def delete(self, bucket=None):
153152
"""
154153
def internal_delete(bucket):
155154
if self.__es.indices.exists_alias(name=bucket):
156-
existing_index_names = self.__es.indices.get_alias(bucket)
155+
existing_index_names = self.__es.indices.get_alias(name=bucket)
157156
existing_index_names = list(existing_index_names.keys())
158157
for existing_index_name in existing_index_names:
159-
self.__es.indices.delete(existing_index_name)
158+
self.__es.indices.delete(index=existing_index_name)
160159

161160
if bucket is None:
162161
for bucket in self.buckets:
@@ -226,4 +225,4 @@ def actions(rows_, primary_key_, update_):
226225
else:
227226
collections.deque(iter, maxlen=0)
228227

229-
self.__es.indices.flush(bucket)
228+
self.__es.indices.flush(index=bucket)

0 commit comments

Comments
 (0)