bugfix: prevent RuntimeError from catching NotImplementedError (#1280)

* prevent RuntimeError from catching NotImplementedError

* add test for bad multiple syncs

Author: mukhery

fsspec/asyn.py

@@ -83,6 +83,8 @@ def sync(loop, func, *args, timeout=None, **kwargs):
         loop0 = asyncio.events.get_running_loop()
         if loop0 is loop:
             raise NotImplementedError("Calling sync() from within a running loop")
+    except NotImplementedError:
+        raise
     except RuntimeError:
         pass
     coro = func(*args, **kwargs)

fsspec/tests/test_async.py

@@ -53,7 +53,12 @@ async def _dummy_async_func(self):
         await asyncio.sleep(1)
         return True
 
+    async def _bad_multiple_sync(self):
+        fsspec.asyn.sync_wrapper(_DummyAsyncKlass._dummy_async_func)(self)
+        return True
+
     dummy_func = fsspec.asyn.sync_wrapper(_dummy_async_func)
+    bad_multiple_sync_func = fsspec.asyn.sync_wrapper(_bad_multiple_sync)
 
 
 def test_sync_wrapper_timeout_on_less_than_expected_wait_time_not_finish_function():
@@ -77,6 +82,12 @@ def test_sync_wrapper_treat_timeout_0_as_none():
     assert test_obj.dummy_func(timeout=0)
 
 
+def test_sync_wrapper_bad_multiple_sync():
+    test_obj = _DummyAsyncKlass()
+    with pytest.raises(NotImplementedError):
+        test_obj.bad_multiple_sync_func(timeout=5)
+
+
 def test_run_coros_in_chunks(monkeypatch):
     total_running = 0