Skip to content

Commit af0cfd5

Browse files
committed
#5 debugging failing tailer test on Darwin
1 parent a1cf7bd commit af0cfd5

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

tailer/fswatcher/fseventProducerLoop_darwin.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,6 @@ type keventloop struct {
2626
done chan struct{}
2727
}
2828

29-
type Kevent syscall.Kevent_t
30-
3129
// Terminate the kevent loop.
3230
// If the loop hangs in syscall.Kevent(), it will keep hanging there until the next event is read.
3331
// Therefore, after the consumer called Close(), it should interrupt the kevent() call by closing the kq descriptor.
@@ -86,7 +84,7 @@ func runKeventLoop(kq int) *keventloop {
8684
return result
8785
}
8886

89-
func (event Kevent) String() string {
87+
func event2string(event syscall.Kevent_t) string {
9088
result := make([]string, 0, 1)
9189
if event.Fflags&syscall.NOTE_DELETE == syscall.NOTE_DELETE {
9290
result = append(result, "NOTE_DELETE")

tailer/fswatcher/fswatcher_darwin.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,20 +120,20 @@ func (w *watcher) processEvent(t *fileTailer, event fsevent, log logrus.FieldLog
120120
for _, dir = range t.watchedDirs {
121121
if kevent.Ident == fdToInt(dir.file.Fd()) {
122122
dirLogger = log.WithField("directory", dir.file.Name())
123-
dirLogger.Debugf("dir event: %v", kevent)
123+
dirLogger.Debugf("dir event: %v", event2string(kevent))
124124
return w.processDirEvent(t, kevent, dir, dirLogger)
125125
}
126126
}
127127
for _, file = range t.watchedFiles {
128128
if kevent.Ident == fdToInt(file.file.Fd()) {
129129
fileLogger = log.WithField("file", file.file.Name()).WithField("fd", file.file.Fd())
130-
fileLogger.Debugf("file event: %v", kevent)
130+
fileLogger.Debugf("file event: %v", event2string(kevent))
131131
return w.processFileEvent(t, kevent, file, fileLogger)
132132
}
133133
}
134134
// Events for unknown file descriptors are ignored. This might happen if syncFilesInDir() already
135135
// closed a file while a pending event is still coming in.
136-
log.Debugf("event for unknown file descriptor %v: %v", kevent.Ident, kevent)
136+
log.Debugf("event for unknown file descriptor %v: %v", kevent.Ident, event2string(kevent))
137137
return nil
138138
}
139139

0 commit comments

Comments
 (0)