Fix lint errors and warnings

Author: natefoo

meta/main.yml

@@ -9,21 +9,21 @@ galaxy_info:
   min_ansible_version: 2.7
   github_branch: main
   platforms:
-  - name: EL
-    versions:
-    - all
-  - name: Fedora
-    versions:
-    - all
-  - name: Ubuntu
-    versions:
-    - all
-  - name: Debian
-    versions:
-    - all
+    - name: EL
+      versions:
+        - all
+    - name: Fedora
+      versions:
+        - all
+    - name: Ubuntu
+      versions:
+        - all
+    - name: Debian
+      versions:
+        - all
   galaxy_tags:
-  - database
-  - sql
-  - postgres
-  - postgresql
+    - database
+    - sql
+    - postgres
+    - postgresql
 dependencies: []

tasks/backup.yml

@@ -46,7 +46,8 @@
     dest: "{{ postgresql_conf_dir }}/conf.d/20ansible_backup.conf"
     owner: postgres
     group: postgres
-    backup: yes
+    mode: 0644
+    backup: true
   notify: Reload PostgreSQL
 
 - name: Schedule backups

tasks/debian.yml

@@ -13,7 +13,7 @@
 - name: Install pgdg repository (Debian/pgdg)
   apt_repository:
     repo: "deb http://apt.postgresql.org/pub/repos/apt/ {{ ansible_distribution_release }}-pgdg main"
-    update_cache: yes
+    update_cache: true
   when: postgresql_flavor is defined and postgresql_flavor == "pgdg"
 
 - name: Install PostgreSQL (Debian)

tasks/main.yml

@@ -35,6 +35,7 @@
     state: directory
     owner: "{{ postgresql_user_name }}"
     group: "{{ postgresql_user_name }}"
+    mode: 0755
 
 # lineinfile's behavior when `backrefs = True` is very odd. We don't want to overwrite include_dirs if it's already
 # properly set, but we don't know the exact format it will be in (with or without '=', with a comment at end of line,
@@ -56,15 +57,15 @@
   lineinfile:
     line: "include_dir 'conf.d'"
     path: "{{ postgresql_conf_dir }}/postgresql.conf"
-    backup: yes
+    backup: true
   notify: Reload PostgreSQL
   when: "postgresql_version is version_compare('9.3', '>=') and __postgresql_include_dir_result is changed"
 
 - name: Include 25ansible_postgresql.conf in postgresql.conf
   lineinfile:
     line: "include 'conf.d/25ansible_postgresql.conf'"
     dest: "{{ postgresql_conf_dir }}/postgresql.conf"
-    backup: yes
+    backup: true
   notify: Reload PostgreSQL
   when: "postgresql_version is version_compare('9.3', '<')"
 
@@ -74,7 +75,8 @@
     dest: "{{ postgresql_conf_dir }}/conf.d/25ansible_postgresql.conf"
     owner: "{{ postgresql_user_name }}"
     group: "{{ postgresql_user_name }}"
-    backup: yes
+    mode: 0644
+    backup: true
   notify: Reload PostgreSQL
 
 - name: Install pg_hba.conf
@@ -84,7 +86,7 @@
     owner: "{{ postgresql_user_name }}"
     group: "{{ postgresql_user_name }}"
     mode: 0400
-    backup: yes
+    backup: true
   notify: Reload PostgreSQL
 
 - include_tasks: backup.yml
@@ -93,5 +95,5 @@
 - name: Ensure PostgreSQL is running
   service:
     name: "{{ postgresql_service_name }}"
-    enabled: yes
+    enabled: true
     state: started

tasks/redhat.yml

@@ -11,7 +11,7 @@
   yum:
     name: "pgdg-redhat-repo"
   register: __postgresql_repo_pkg_installed_result
-  ignore_errors: yes
+  ignore_errors: true
 
 - name: Install pgdg repository package (RedHat)
   yum:
@@ -25,22 +25,22 @@
   delay: 5
   when: __postgresql_repo_pkg_installed_result is failed
 
-#- name: Collect installed repos
-#  yum:
-#    list: repos
-#  until: __postgresql_yum_repolist_result is succeeded
-#  retries: 5
-#  delay: 5
-#  register: __postgresql_yum_repolist_result
+# - name: Collect installed repos
+#   yum:
+#     list: repos
+#   until: __postgresql_yum_repolist_result is succeeded
+#   retries: 5
+#   delay: 5
+#   register: __postgresql_yum_repolist_result
 
 # Not supported (and no good workaround) until there is a solution for https://github.com/ansible/ansible/issues/41178
-#- name: Ensure that only the desired PostgreSQL version's repo is enabled
-#  yum_repository:
-#    name: item.repoid
-#    enabled: "{{ (item.repoid == 'pgdg' ~ __postgresql_version_dotless) if item.repoid.startswith('pgdg') else item.state == 'enabled' }}"
-#  # "{{ __postgresql_yum_repolist_result.results | selectattr('repoid', 'startswith', 'pgdg') | list }}" would be nice
-#  # here but alas there is no `startswith` test
-#  loop: "{{ __postgresql_yum_repolist_result.results }}"
+# - name: Ensure that only the desired PostgreSQL version's repo is enabled
+#   yum_repository:
+#     name: item.repoid
+#     enabled: "{{ (item.repoid == 'pgdg' ~ __postgresql_version_dotless) if item.repoid.startswith('pgdg') else item.state == 'enabled' }}"
+#   # "{{ __postgresql_yum_repolist_result.results | selectattr('repoid', 'startswith', 'pgdg') | list }}" would be nice
+#   # here but alas there is no `startswith` test
+#   loop: "{{ __postgresql_yum_repolist_result.results }}"
 
 - name: Install PostgreSQL (RedHat)
   yum:

vars/main.yml

@@ -2,9 +2,9 @@
 
 # maps ansible_* to the pgdg repository package name
 postgresql_pgdg_families:
-  #default: redhat
+  # default: redhat
   Fedora: fedora
 
 postgresql_pgdg_shortfamilies:
-  #default: EL
+  # default: EL
   Fedora: F