fix: Align types of rootNodeMap during root node tracking (#39262)

sdobz · pieh · commit ac26f3632b9b · 2025-04-08T10:18:05.000+02:00
* fix(gatsby): change ids in findRootNodeAncestor from array to set (#39261) * Update packages/gatsby/src/schema/node-model.js Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com> * chore: fix lint --------- Co-authored-by: sdobz <vincent+WSL@khougaz.com> Co-authored-by: Michal Piechowiak <misiek.piechowiak@gmail.com> (cherry picked from commit 1825669)
diff --git a/packages/gatsby/src/schema/node-model.js b/packages/gatsby/src/schema/node-model.js
@@ -521,10 +521,10 @@ class LocalNodeModel {
     let iterations = 0
     let ids = this._rootNodeMap.get(obj)
     if (!ids) {
-      ids = []
+      ids = new Set()
     }
-    if (obj?.parent) {
-      ids.push(obj.parent)
+    if (obj?.parent && typeof obj.parent === `string`) {
+      ids.add(obj.parent)
     }
     let matchingRoot = null
 

Original file line number	Diff line number	Diff line change
`@@ -521,10 +521,10 @@ class LocalNodeModel {`
`521`	`521`	`let iterations = 0`
`522`	`522`	`let ids = this._rootNodeMap.get(obj)`
`523`	`523`	`if (!ids) {`
`524`		`- ids = []`
	`524`	`+ ids = new Set()`
`525`	`525`	`}`
`526`		`- if (obj?.parent) {`
`527`		`- ids.push(obj.parent)`
	`526`	+ if (obj?.parent && typeof obj.parent === `string`) {
	`527`	`+ ids.add(obj.parent)`
`528`	`528`	`}`
`529`	`529`	`let matchingRoot = null`
`530`	`530`