Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor benchmarking code #1002

Open
gw265981 opened this issue Mar 20, 2025 · 0 comments
Open

Refactor benchmarking code #1002

gw265981 opened this issue Mar 20, 2025 · 0 comments
Labels
enhancement New feature or request new Something yet to be discussed by development team

Comments

@gw265981
Copy link
Contributor

What's the new feature?

As the number of solvers has grown, updating benchmarking results has become cumbersome. Ideally, we would have single script to define the solvers and run the set of benchmarks.

Some identified issues:

  • Currently most solvers are setup in coreax/benchmark_util.py in the initialise_solvers() function. However benchmark/blobs_benchmark.py has separate code for this, which requires defining new methods in both places.
  • Make the save paths more robust to make sure benchmarking results and images are saved to the appropriate location (currently examples/benchmarking_images) regardless of where the script is run from.
  • Consider creating a script that contains basic configurations, runs all benchmarking and visualisation scripts, and updates the benchmark.rst documentation page.
  • Document the benchmarking process and conventions in CONTRIBUTING.md.
  • Refactor existing code to avoid local imports from other coreax packages.
  • Make sure the code adheres to the usual standards, e.g., for docstrings and typing.
  • Investigate optimisation possibilities, e.g., caching some parts of computation, parallelising test runs.

Some suggestions are given in #1000.

What value does this add?

Easier to benchmark new and existing coreset algorithms.

Is there an alternative you've considered?

No response

Additional context

No response

@gw265981 gw265981 added enhancement New feature or request new Something yet to be discussed by development team labels Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new Something yet to be discussed by development team
Projects
None yet
Development

No branches or pull requests

1 participant