Update eslint

Author: abraham

firestore.rules.test.ts

@@ -99,6 +99,7 @@ describe.skip('firestore', () => {
 
       it('data validation', () => {
         expect(updateDoc(ownDocRef, {})).toAllow();
+
         [
           { contentRating: -1 },
           { contentRating: 11 },

package-lock.json

@@ -83,18 +83,18 @@
     "@types/node": "^22.13.10",
     "@types/nunjucks": "^3.2.6",
     "@types/polymer": "^1.2.16",
-    "@typescript-eslint/eslint-plugin": "^7.4.0",
+    "@typescript-eslint/eslint-plugin": "^7.18.0",
     "@typescript-eslint/parser": "^7.7.1",
     "@web/rollup-plugin-html": "^2.3.0",
     "concurrently": "^9.1.2",
-    "eslint": "^8.57.0",
+    "eslint": "^8.57.1",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-import-resolver-typescript": "^3.6.1",
-    "eslint-plugin-html": "^8.0.0",
-    "eslint-plugin-import": "^2.29.1",
-    "eslint-plugin-jest": "^28.5.0",
-    "eslint-plugin-jest-dom": "^5.4.0",
-    "eslint-plugin-testing-library": "^6.2.0",
+    "eslint-import-resolver-typescript": "^3.8.3",
+    "eslint-plugin-html": "^8.1.2",
+    "eslint-plugin-import": "^2.31.0",
+    "eslint-plugin-jest": "^28.11.0",
+    "eslint-plugin-jest-dom": "^5.5.0",
+    "eslint-plugin-testing-library": "^6.5.0",
     "firebase-admin": "^12.7.0",
     "firebase-tools": "^13.33.0",
     "jest": "^29.7.0",

package.json

@@ -38,6 +38,7 @@ describe('about-block', () => {
     const { getByText } = within(shadowRootForWithin);
 
     fireEvent.click(getByText(aboutBlock.callToAction.howItWas.label));
+
     expect(mockToggleVideoDialogs).toHaveBeenCalledTimes(1);
     expect(mockToggleVideoDialogs).toHaveBeenCalledWith({
       title: aboutBlock.callToAction.howItWas.label,

src/components/about-block.test.ts

@@ -40,7 +40,9 @@ describe('auth-required', () => {
 
   it('shows unauthenticated prompt', () => {
     expect(shadowRoot.querySelector<HTMLDivElement>('mwc-button')).not.toHaveAttribute('hidden');
+
     const slots = shadowRoot.querySelectorAll('slot');
+
     expect(slots).toHaveLength(2);
     expect(slots[0]).not.toHaveAttribute('hidden');
     expect(slots[0]).toHaveAttribute('name', 'prompt');
@@ -52,6 +54,7 @@ describe('auth-required', () => {
 
   it('opens dialog on tap', () => {
     fireEvent.click(shadowRoot.querySelector('mwc-button')!);
+
     expect(mockOpenDialog).toHaveBeenCalledTimes(1);
   });
 
@@ -61,8 +64,11 @@ describe('auth-required', () => {
       payload: { uid: '1' } as User,
     });
     await element.updateComplete;
+
     expect(shadowRoot.querySelector<HTMLDivElement>('mwc-button')).toHaveAttribute('hidden');
+
     const slots = shadowRoot.querySelectorAll('slot');
+
     expect(slots).toHaveLength(2);
     expect(slots[0]).toHaveAttribute('hidden');
     expect(slots[1]).not.toHaveAttribute('hidden');

src/components/auth-required.test.ts

@@ -22,6 +22,7 @@ describe('hero-block', () => {
 
   it('has default values', async () => {
     const { element, shadowRoot } = await fixture<HeroBlock>(html`<hero-block></hero-block>`);
+
     expect(element.backgroundImage).toBe('');
     expect(element.backgroundColor).toBe('#fff');
     expect(element.fontColor).toBe('#000');
@@ -39,6 +40,7 @@ describe('hero-block', () => {
         hide-logo
       ></hero-block>
     `);
+
     expect(element.backgroundImage).toBe('/example.jpg');
     expect(element.backgroundColor).toBe('#000');
     expect(element.fontColor).toBe('#fff');
@@ -55,6 +57,7 @@ describe('hero-block', () => {
       </hero-block>
     `);
     const slots = shadowRoot.querySelectorAll('slot');
+
     expect(slots).toHaveLength(2);
     expect(screen.getByText('default slot')).toBeVisible();
     expect(slots[0]).not.toHaveAttribute('name');
@@ -68,11 +71,13 @@ describe('hero-block', () => {
     const { shadowRoot } = await fixture<HeroBlock>(
       html`<hero-block background-image="/example.jpg"></hero-block>`,
     );
+
     expect(shadowRoot.querySelector('.hero-image')).toHaveAttribute('src', '/example.jpg');
   });
 
   it('setHeroSettings notifies', async () => {
     await fixture<HeroBlock>(html`<hero-block background-image="/example.jpg"></hero-block>`);
+
     expect(mockSetHeroSettings).toHaveBeenCalledTimes(1);
     expect(mockSetHeroSettings).toHaveBeenCalledWith({
       backgroundColor: '#fff',

src/components/hero/hero-block.test.ts

@@ -7,6 +7,7 @@ describe('badge', () => {
   it('matches the shape of the default data', () => {
     const badges: Badge[] = Object.values(data['speakers']['dmytro_danylyk']['badges']);
     const keys: Array<keyof Badge> = ['description', 'link', 'name'];
+
     expect(badges).toHaveLength(2);
     expect(allKeys(badges)).toStrictEqual(keys);
   });

src/models/badge.test.ts

@@ -7,6 +7,7 @@ describe('day', () => {
   it('matches the shape of the default data', () => {
     const days: Day[] = Object.values(data['schedule']);
     const keys: Array<keyof Day> = ['date', 'dateReadable', 'timeslots', 'tracks'];
+
     expect(days).toHaveLength(2);
     expect(allKeys(days)).toStrictEqual(keys);
   });

src/models/day.test.ts

@@ -12,6 +12,7 @@ describe('feedback', () => {
       },
     ];
     const keys: Array<keyof FeedbackData> = ['comment', 'contentRating', 'styleRating'];
+
     expect(feedback).toHaveLength(1);
     expect(allKeys(feedback)).toStrictEqual(keys);
   });

src/models/feedback.test.ts

@@ -13,6 +13,7 @@ describe('hero', () => {
       },
     ];
     const keys: Array<keyof Hero> = ['backgroundColor', 'backgroundImage', 'fontColor', 'hideLogo'];
+
     expect(heros).toHaveLength(1);
     expect(allKeys(heros)).toStrictEqual(keys);
   });

src/models/hero.test.ts

@@ -14,6 +14,7 @@ describe('partner', () => {
       'socials',
       'title',
     ];
+
     expect(members).toHaveLength(8);
     expect(allKeys(members)).toStrictEqual(keys);
   });

src/models/member.test.ts

@@ -7,6 +7,7 @@ describe('partner', () => {
   it('matches the shape of the default data', () => {
     const partner: PartnerGroupData[] = Object.values(data['partners']);
     const keys: Array<keyof PartnerGroupData> = ['items', 'order', 'title'];
+
     expect(partner).toHaveLength(2);
     expect(allKeys(partner)).toStrictEqual(keys);
   });

src/models/partner-group.test.ts

@@ -7,6 +7,7 @@ describe('partner', () => {
   it('matches the shape of the default data', () => {
     const posts: PartnerData[] = Object.values(data['partners'][1]!['items']);
     const keys: Array<keyof PartnerData> = ['logoUrl', 'name', 'order', 'url'];
+
     expect(posts).toHaveLength(11);
     expect(allKeys(posts)).toStrictEqual(keys);
   });

src/models/partner.test.ts

@@ -15,6 +15,7 @@ describe('post', () => {
       'source',
       'title',
     ];
+
     expect(posts).toHaveLength(5);
     expect(allKeys(posts)).toStrictEqual(keys);
   });

src/models/post.test.ts

@@ -9,6 +9,7 @@ describe('speaker', () => {
       data['previousSpeakers']['adrian_kajda']['sessions']['2016'],
     );
     const keys: Array<keyof PreviousSession> = ['presentation', 'tags', 'title', 'videoId'];
+
     expect(sessions).toHaveLength(1);
     expect(allKeys(sessions)).toStrictEqual(keys);
   });

src/models/previous-session.test.ts

@@ -19,6 +19,7 @@ describe('speaker', () => {
       'socials',
       'title',
     ];
+
     expect(speakers).toHaveLength(22);
     expect(allKeys(speakers)).toStrictEqual(keys);
   });

src/models/previous-speaker.test.ts

@@ -19,6 +19,7 @@ describe('session', () => {
       'title',
       'videoId',
     ];
+
     expect(sessions).toHaveLength(40);
     expect(allKeys(sessions)).toStrictEqual(keys);
   });

src/models/session.test.ts

@@ -7,6 +7,7 @@ describe('speaker', () => {
   it('matches the shape of the default data', () => {
     const socials: Social[] = Object.values(data['speakers']['aleksander_piotrowski']['socials']);
     const keys: Array<keyof Social> = ['icon', 'link', 'name'];
+
     expect(socials).toHaveLength(4);
     expect(allKeys(socials)).toStrictEqual(keys);
   });

src/models/social.test.ts

@@ -23,6 +23,7 @@ describe('speaker', () => {
       'socials',
       'title',
     ];
+
     expect(speakers).toHaveLength(27);
     expect(allKeys(speakers)).toStrictEqual(keys);
   });

src/models/speaker.test.ts

@@ -12,6 +12,7 @@ describe('partner', () => {
   it('matches the shape of the default data', () => {
     const teams: Team[] = Object.values(data['team']);
     const keys: Array<keyof Team> = ['members', 'title'];
+
     expect(teams).toHaveLength(2);
     expect(allKeys(teams)).toStrictEqual(keys);
   });

src/models/team.test.ts

@@ -20,6 +20,7 @@ describe('ticket', () => {
       'starts',
       'url',
     ];
+
     expect(tickets).toHaveLength(5);
     expect(allKeys(tickets)).toStrictEqual(keys);
   });

src/models/ticket.test.ts

@@ -7,6 +7,7 @@ describe('time', () => {
   it('matches the shape of the default data', () => {
     const times: Time[] = data['schedule']['2016-09-09']['timeslots'][3]!['sessions'];
     const keys: Array<keyof Time> = ['extend', 'items'];
+
     expect(times).toHaveLength(3);
     expect(allKeys(times)).toStrictEqual(keys);
   });

src/models/time.test.ts

@@ -7,6 +7,7 @@ describe('timeslot', () => {
   it('matches the shape of the default data', () => {
     const days: Timeslot[] = data['schedule']['2016-09-09']['timeslots'];
     const keys: Array<keyof Timeslot> = ['endTime', 'sessions', 'startTime'];
+
     expect(days).toHaveLength(13);
     expect(allKeys(days)).toStrictEqual(keys);
   });

src/models/timeslot.test.ts

@@ -7,6 +7,7 @@ describe('track', () => {
   it('matches the shape of the default data', () => {
     const days: Track[] = data['schedule']['2016-09-09']['tracks'];
     const keys: Array<keyof Track> = ['title'];
+
     expect(days).toHaveLength(3);
     expect(allKeys(days)).toStrictEqual(keys);
   });

src/models/track.test.ts

@@ -7,6 +7,7 @@ describe('video', () => {
   it('matches the shape of the default data', () => {
     const videos: Video[] = Object.values(data['videos']);
     const keys: Array<keyof Video> = ['speakers', 'thumbnail', 'title', 'youtubeId'];
+
     expect(videos).toHaveLength(22);
     expect(allKeys(videos)).toStrictEqual(keys);
   });

src/models/video.test.ts

@@ -28,11 +28,13 @@ describe('share', () => {
 
   it('shares to Twitter', () => {
     share({ currentTarget: fixture('twitter') } as any as PointerEvent);
+
     expect(window.open).toHaveBeenCalledWith(twitterUrl, 'share', features(275));
   });
 
   it('shares to Facebook', () => {
     share({ currentTarget: fixture('facebook') } as any as PointerEvent);
+
     expect(window.open).toHaveBeenCalledWith(
       'https://www.facebook.com/sharer.php?u=http%3A%2F%2Flocalhost%2F&t=Awesome%20Schedule',
       'share',
@@ -42,6 +44,7 @@ describe('share', () => {
 
   it('throws on unknown', () => {
     const event = { currentTarget: fixture('unknown') } as any as PointerEvent;
+
     expect(() => share(event)).toThrow('Unknown share target');
   });
 });