Skip to content

Add cacheDirPath to Options #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philipphofmann opened this issue Apr 19, 2021 · 6 comments
Closed

Add cacheDirPath to Options #1051

philipphofmann opened this issue Apr 19, 2021 · 6 comments

Comments

@philipphofmann
Copy link
Member

The SDK uses the Library/Cache folder caching SDK and SentryCrash data. The downside of this is that the OS might delete data in this folder when it needs more disk space or the user can as well delete these caches. We can add something like a cacheDirPath, as we already have it in sentry-java to give our users the possibility to change the location of our cache data. A customer of ours already requested this.

@bruno-garcia
Copy link
Member

Name used in other SDKs:

sentry-native: sentry_options_set_database_path
sentry-android/java: cacheDirPath
sentry-dotnet: CacheDirectoryPath

@philipphofmann
Copy link
Member Author

The Swift and Objective-C way to go would be to name it cacheDirectoryPath.

@mattjohnsonpint
Copy link
Contributor

This will be useful for getsentry/sentry-dotnet#1282 also. Can we bump the priority please? Thanks.

@philipphofmann
Copy link
Member Author

@mattjohnsonpint, the other hybrid SDKs don't need this feature; why would it be useful for getsentry/sentry-dotnet#1282?

@mattjohnsonpint
Copy link
Contributor

It's not absolutely required, as long as the cache paths are distinct between the different SDKs so they don't step on each other. But being able to specify the cache path gives me better control over that.

@philipphofmann
Copy link
Member Author

We found a workaround for .NET, and we don't need to align with the other SDKs just to align. To keep the SDK smaller and simpler, we close this for now. We can always reopen if needed.

Repository owner moved this from Backlog to Done in [DEPRECATED] Mobile SDKs Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants