Skip to content

Supply correct return type for sentryVitePlugin #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Lutymane opened this issue Apr 16, 2025 · 1 comment · May be fixed by #728
Open

Supply correct return type for sentryVitePlugin #727

Lutymane opened this issue Apr 16, 2025 · 1 comment · May be fixed by #728
Assignees
@chargome

Comments

@Lutymane
Copy link

The factory function actually returns an array of plugins which caused issues with plugin management with an expectation it returns a single plugin. It should be noted either in docs, or properly typed to avoid issues for other users.

sentry-javascript-bundler-plugins/packages/vite-plugin/src/index.ts

Line 77 in 9c56454

export const sentryVitePlugin: (options?: Options) => any = sentryUnplugin.vite;

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Apr 16, 2025
@chargome chargome self-assigned this Apr 17, 2025
@chargome
Copy link
Member

Hey @Lutymane, thanks for writing in – we'll have a look!

@chargome chargome linked a pull request Apr 17, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chargome chargome

Labels
None yet
Projects
GitHub Issues with 👀 3
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(vite): Update return type of vite plugin getsentry/sentry-javascript-bundler-plugins
2 participants
@chargome @Lutymane