Skip to content

Commit 17c0c2e

Browse files
fix(android): Add missing methods into the old arch interface (#4751)
1 parent b3e6131 commit 17c0c2e

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
- Avoid silent failure when JS bundle was not created due to Sentry Xcode scripts failure ([#4690](https://github.com/getsentry/sentry-react-native/pull/4690))
1414
- Prevent crash on iOS during profiling stop when debug images are missing ([#4738](https://github.com/getsentry/sentry-react-native/pull/4738))
1515
- Attach only App Starts within the 60s threshold (fixed comparison units, use ms) ([#4746](https://github.com/getsentry/sentry-react-native/pull/4746))
16+
- Add missing `popTimeToDisplayFor` in to the Android Old Arch Native interface([#4751](https://github.com/getsentry/sentry-react-native/pull/4751))
1617

1718
### Dependencies
1819

packages/core/android/src/oldarch/java/io/sentry/react/RNSentryModule.java

+11-6
Original file line numberDiff line numberDiff line change
@@ -152,11 +152,6 @@ public String fetchNativePackageName() {
152152
return this.impl.fetchNativePackageName();
153153
}
154154

155-
@ReactMethod
156-
public void getDataFromUri(String uri, Promise promise) {
157-
this.impl.getDataFromUri(uri, promise);
158-
}
159-
160155
@ReactMethod(isBlockingSynchronousMethod = true)
161156
public WritableMap fetchNativeStackFramesBy(ReadableArray instructionsAddr) {
162157
// Not used on Android
@@ -178,11 +173,21 @@ public void crashedLastRun(Promise promise) {
178173
this.impl.crashedLastRun(promise);
179174
}
180175

181-
@ReactMethod()
176+
@ReactMethod
182177
public void getNewScreenTimeToDisplay(Promise promise) {
183178
this.impl.getNewScreenTimeToDisplay(promise);
184179
}
185180

181+
@ReactMethod
182+
public void getDataFromUri(String uri, Promise promise) {
183+
this.impl.getDataFromUri(uri, promise);
184+
}
185+
186+
@ReactMethod
187+
public void popTimeToDisplayFor(String key, Promise promise) {
188+
this.impl.popTimeToDisplayFor(key, promise);
189+
}
190+
186191
@ReactMethod
187192
public boolean setActiveSpanId(String spanId) {
188193
return this.impl.setActiveSpanId(spanId);

0 commit comments

Comments
 (0)