Skip to content

Commit 5b6a435

Browse files
committed
Set active_job_report_after_job_retries to true by default
Refs #2598 Refs #2597
1 parent 8c699de commit 5b6a435

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

sentry-rails/lib/sentry/rails/configuration.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ def initialize
176176
@enable_db_query_source = true
177177
@db_query_source_threshold_ms = 100
178178
@active_support_logger_subscription_items = Sentry::Rails::ACTIVE_SUPPORT_LOGGER_SUBSCRIPTION_ITEMS_DEFAULT.dup
179-
@active_job_report_after_job_retries = false
179+
@active_job_report_after_job_retries = true
180180
end
181181
end
182182
end

sentry-rails/spec/sentry/rails/activejob_spec.rb

+9-8
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,16 @@ def perform(event, hint)
441441
end
442442
end
443443

444+
444445
context "when active_job_report_after_job_retries is false" do
446+
before do
447+
Sentry.configuration.rails.active_job_report_after_job_retries = false
448+
end
449+
450+
after do
451+
Sentry.configuration.rails.active_job_report_after_job_retries = true
452+
end
453+
445454
it "reports 3 exceptions" do
446455
allow(Sentry::Rails::ActiveJobExtensions::SentryReporter)
447456
.to receive(:capture_exception).and_call_original
@@ -459,14 +468,6 @@ def perform(event, hint)
459468
end
460469

461470
context "when active_job_report_after_job_retries is true" do
462-
before do
463-
Sentry.configuration.rails.active_job_report_after_job_retries = true
464-
end
465-
466-
after do
467-
Sentry.configuration.rails.active_job_report_after_job_retries = false
468-
end
469-
470471
it "reports 1 exception" do
471472
allow(Sentry::Rails::ActiveJobExtensions::SentryReporter)
472473
.to receive(:capture_exception).and_call_original

sentry-rails/spec/sentry/rails/configuration_spec.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class MySubscriber; end
6262

6363
describe "#active_job_report_after_job_retries" do
6464
it "has correct default value" do
65-
expect(subject.active_job_report_after_job_retries).to eq(false)
65+
expect(subject.active_job_report_after_job_retries).to be(true)
6666
end
6767
end
6868
end

0 commit comments

Comments
 (0)