Skip to content

Commit 38e36ef

Browse files
authored
🔧 chore(integrations): use IntegrationProviderSlug for Integration key (#91465)
1 parent 993bddb commit 38e36ef

File tree

10 files changed

+21
-12
lines changed

10 files changed

+21
-12
lines changed

src/sentry/integrations/discord/integration.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
from sentry.integrations.discord.client import DiscordClient
2323
from sentry.integrations.discord.types import DiscordPermissions
2424
from sentry.integrations.models.integration import Integration
25+
from sentry.integrations.types import IntegrationProviderSlug
2526
from sentry.organizations.services.organization.model import RpcOrganization
2627
from sentry.pipeline.base import Pipeline
2728
from sentry.pipeline.views.base import PipelineView
@@ -117,7 +118,7 @@ def uninstall(self) -> None:
117118

118119

119120
class DiscordIntegrationProvider(IntegrationProvider):
120-
key = "discord"
121+
key = IntegrationProviderSlug.DISCORD.value
121122
name = "Discord"
122123
metadata = metadata
123124
integration_cls = DiscordIntegration

src/sentry/integrations/github/integration.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@
4949
from sentry.integrations.source_code_management.repo_trees import RepoTreesIntegration
5050
from sentry.integrations.source_code_management.repository import RepositoryIntegration
5151
from sentry.integrations.tasks.migrate_repo import migrate_repo
52+
from sentry.integrations.types import IntegrationProviderSlug
5253
from sentry.integrations.utils.metrics import (
5354
IntegrationPipelineViewEvent,
5455
IntegrationPipelineViewType,
@@ -648,7 +649,7 @@ def format_issue_table(
648649

649650

650651
class GitHubIntegrationProvider(IntegrationProvider):
651-
key = "github"
652+
key = IntegrationProviderSlug.GITHUB.value
652653
name = "GitHub"
653654
metadata = metadata
654655
integration_cls: type[IntegrationInstallation] = GitHubIntegration

src/sentry/integrations/github_enterprise/integration.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
from sentry.integrations.services.repository.model import RpcRepository
2727
from sentry.integrations.source_code_management.commit_context import CommitContextIntegration
2828
from sentry.integrations.source_code_management.repository import RepositoryIntegration
29+
from sentry.integrations.types import IntegrationProviderSlug
2930
from sentry.models.repository import Repository
3031
from sentry.organizations.services.organization.model import RpcOrganization
3132
from sentry.pipeline import NestedPipelineView, Pipeline, PipelineView
@@ -155,7 +156,7 @@ class GitHubEnterpriseIntegration(
155156

156157
@property
157158
def integration_name(self) -> str:
158-
return "github_enterprise"
159+
return IntegrationProviderSlug.GITHUB_ENTERPRISE.value
159160

160161
def get_client(self):
161162
if not self.org_integration:
@@ -371,7 +372,7 @@ def dispatch(self, request: HttpRequest, pipeline: Pipeline) -> HttpResponseBase
371372

372373

373374
class GitHubEnterpriseIntegrationProvider(GitHubIntegrationProvider):
374-
key = "github_enterprise"
375+
key = IntegrationProviderSlug.GITHUB_ENTERPRISE.value
375376
name = "GitHub Enterprise"
376377
metadata = metadata
377378
integration_cls = GitHubEnterpriseIntegration

src/sentry/integrations/jira/integration.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
from sentry.integrations.models.external_issue import ExternalIssue
2929
from sentry.integrations.models.integration_external_project import IntegrationExternalProject
3030
from sentry.integrations.services.integration import integration_service
31+
from sentry.integrations.types import IntegrationProviderSlug
3132
from sentry.issues.grouptype import GroupCategory
3233
from sentry.issues.issue_occurrence import IssueOccurrence
3334
from sentry.models.group import Group
@@ -1106,7 +1107,7 @@ def parse_jira_issue_metadata(
11061107

11071108

11081109
class JiraIntegrationProvider(IntegrationProvider):
1109-
key = "jira"
1110+
key = IntegrationProviderSlug.JIRA.value
11101111
name = "Jira"
11111112
metadata = metadata
11121113
integration_cls = JiraIntegration

src/sentry/integrations/jira_server/integration.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
from sentry.integrations.models.external_issue import ExternalIssue
3535
from sentry.integrations.models.integration_external_project import IntegrationExternalProject
3636
from sentry.integrations.services.integration import integration_service
37-
from sentry.integrations.types import ExternalProviders
37+
from sentry.integrations.types import ExternalProviders, IntegrationProviderSlug
3838
from sentry.models.group import Group
3939
from sentry.organizations.services.organization.service import organization_service
4040
from sentry.pipeline import Pipeline, PipelineView
@@ -1372,7 +1372,7 @@ def migrate_issues(self):
13721372

13731373

13741374
class JiraServerIntegrationProvider(IntegrationProvider):
1375-
key = "jira_server"
1375+
key = IntegrationProviderSlug.JIRA_SERVER.value
13761376
name = "Jira Server"
13771377
metadata = metadata
13781378
integration_cls = JiraServerIntegration

src/sentry/integrations/msteams/integration.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
IntegrationProvider,
1919
)
2020
from sentry.integrations.models.integration import Integration
21+
from sentry.integrations.types import IntegrationProviderSlug
2122
from sentry.organizations.services.organization.model import RpcOrganization
2223
from sentry.pipeline import Pipeline, PipelineView
2324

@@ -79,7 +80,7 @@ def get_client(self) -> MsTeamsClient:
7980

8081

8182
class MsTeamsIntegrationProvider(IntegrationProvider):
82-
key = "msteams"
83+
key = IntegrationProviderSlug.MSTEAMS.value
8384
name = "Microsoft Teams"
8485
can_add = False
8586
metadata = metadata

src/sentry/integrations/opsgenie/integration.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
from sentry.integrations.on_call.metrics import OnCallIntegrationsHaltReason, OnCallInteractionType
2525
from sentry.integrations.opsgenie.metrics import record_event
2626
from sentry.integrations.opsgenie.tasks import migrate_opsgenie_plugin
27+
from sentry.integrations.types import IntegrationProviderSlug
2728
from sentry.organizations.services.organization.model import RpcOrganization
2829
from sentry.pipeline import Pipeline, PipelineView
2930
from sentry.shared_integrations.exceptions import (
@@ -231,7 +232,7 @@ def schedule_migrate_opsgenie_plugin(self):
231232

232233

233234
class OpsgenieIntegrationProvider(IntegrationProvider):
234-
key = "opsgenie"
235+
key = IntegrationProviderSlug.OPSGENIE.value
235236
name = "Opsgenie"
236237
metadata = metadata
237238
integration_cls = OpsgenieIntegration

src/sentry/integrations/pagerduty/integration.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
from sentry.integrations.models.organization_integration import OrganizationIntegration
2525
from sentry.integrations.on_call.metrics import OnCallInteractionType
2626
from sentry.integrations.pagerduty.metrics import record_event
27+
from sentry.integrations.types import IntegrationProviderSlug
2728
from sentry.organizations.services.organization.model import RpcOrganization
2829
from sentry.pipeline import Pipeline, PipelineView
2930
from sentry.shared_integrations.exceptions import IntegrationError
@@ -167,7 +168,7 @@ def services(self) -> list[PagerDutyServiceDict]:
167168

168169

169170
class PagerDutyIntegrationProvider(IntegrationProvider):
170-
key = "pagerduty"
171+
key = IntegrationProviderSlug.PAGERDUTY.value
171172
name = "PagerDuty"
172173
metadata = metadata
173174
features = frozenset([IntegrationFeatures.ALERT_RULE, IntegrationFeatures.INCIDENT_MANAGEMENT])

src/sentry/integrations/slack/integration.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
)
2727
from sentry.integrations.slack.sdk_client import SlackSdkClient
2828
from sentry.integrations.slack.tasks.link_slack_user_identities import link_slack_user_identities
29+
from sentry.integrations.types import IntegrationProviderSlug
2930
from sentry.organizations.services.organization.model import RpcOrganization
3031
from sentry.pipeline import NestedPipelineView
3132
from sentry.pipeline.views.base import PipelineView
@@ -100,7 +101,7 @@ def send_message(self, channel_id: str, message: str) -> None:
100101

101102

102103
class SlackIntegrationProvider(IntegrationProvider):
103-
key = "slack"
104+
key = IntegrationProviderSlug.SLACK.value
104105
name = "Slack"
105106
metadata = metadata
106107
features = frozenset([IntegrationFeatures.CHAT_UNFURL, IntegrationFeatures.ALERT_RULE])

src/sentry/integrations/vsts/integration.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
from sentry.integrations.services.repository import RpcRepository, repository_service
3434
from sentry.integrations.source_code_management.repository import RepositoryIntegration
3535
from sentry.integrations.tasks.migrate_repo import migrate_repo
36+
from sentry.integrations.types import IntegrationProviderSlug
3637
from sentry.integrations.utils.metrics import (
3738
IntegrationPipelineHaltReason,
3839
IntegrationPipelineViewEvent,
@@ -398,7 +399,7 @@ def default_project(self) -> str | None:
398399

399400

400401
class VstsIntegrationProvider(IntegrationProvider):
401-
key = "vsts"
402+
key = IntegrationProviderSlug.AZURE_DEVOPS.value
402403
name = "Azure DevOps"
403404
metadata = metadata
404405
api_version = "4.1"

0 commit comments

Comments
 (0)