fixup! feat(const_eval): impl. fract

ErichDonGubler · ErichDonGubler · commit 7e78aca1960c · 2024-01-29T17:47:47.000-05:00
diff --git a/naga/src/proc/constant_evaluator.rs b/naga/src/proc/constant_evaluator.rs
@@ -955,7 +955,11 @@ impl<'a> ConstantEvaluator<'a> {
                 })
             }
             crate::MathFunction::Fract => {
-                component_wise_float!(self, span, [arg], |e| { Ok([e.fract()]) })
+                component_wise_float!(self, span, [arg], |e| {
+                    // N.B., Rust's definition of `fract` is `e - e.trunc()`, so we can't use that
+                    // here.
+                    Ok([e - e.floor()])
+                })
             }
             crate::MathFunction::Trunc => {
                 component_wise_float!(self, span, [arg], |e| { Ok([e.trunc()]) })

Original file line number	Diff line number	Diff line change
`@@ -955,7 +955,11 @@ impl<'a> ConstantEvaluator<'a> {`
`955`	`955`	`})`
`956`	`956`	`}`
`957`	`957`	`crate::MathFunction::Fract => {`
`958`		`- component_wise_float!(self, span, [arg], \|e\| { Ok([e.fract()]) })`
	`958`	`+ component_wise_float!(self, span, [arg], \|e\| {`
	`959`	+ // N.B., Rust's definition of `fract` is `e - e.trunc()`, so we can't use that
	`960`	`+ // here.`
	`961`	`+ Ok([e - e.floor()])`
	`962`	`+ })`
`959`	`963`	`}`
`960`	`964`	`crate::MathFunction::Trunc => {`
`961`	`965`	`component_wise_float!(self, span, [arg], \|e\| { Ok([e.trunc()]) })`