Skip to content

Commit 1867eba

Browse files
committed
SoC-2022-Microprojects: remove --no-sort entry
1 parent 1b2bf6f commit 1867eba

File tree

1 file changed

+0
-22
lines changed

1 file changed

+0
-22
lines changed

SoC-2022-Microprojects.md

-22
Original file line numberDiff line numberDiff line change
@@ -88,25 +88,3 @@ worked on by asking on the mailing list before starting to work on it.
8888
There should be only one kind of change per commit. For example if one
8989
of your commits indents test bodies with TABs, instead of spaces, then
9090
this should be the only kind of change in this commit.
91-
92-
### Add --no-sort option for git-for-each-ref
93-
94-
In "git for-each-ref", `ref_array_sort()` is used to sort ref_array with
95-
sorting options. Even if the user does not provide any `--sort` option,
96-
`ref_default_sorting()` will also provide the default sorting options with
97-
the sort key "refname".
98-
99-
But it turns out that the ref_array we get through `filter_refs()` is
100-
already sorted by "refname". So providing a `--no-sort` option may
101-
improve the performance of git for-each-ref when we don't provide any
102-
sorting options on the command line. [thread](https://lore.kernel.org/git/[email protected]/),
103-
[thread](https://lore.kernel.org/git/[email protected]/)
104-
105-
But the `--no-sort` option seems to be disabled in "git for-each-ref",
106-
see "NEEDWORK" hint in `parse_opt_ref_sorting()`. You may need a new
107-
list api to replace the original linked list implementation for ref_sorting.
108-
You can refer to the implementation of this patch:
109-
[thread](https://lore.kernel.org/git/e68635cda515a9cd504c1d7366e9c353ab2adb2e.1629882532.git.gitgitgadget@gmail.com/)
110-
111-
You can use t/perf for performance testing between upstream and your patches.
112-
[t/perf/README](https://github.com/git/git/blob/master/t/perf/README)

0 commit comments

Comments
 (0)