JS: Fix possible typo in DominatingPaths::hasWrite

adityasharad · adityasharad · commit 7dc698fd77a1 · 2021-12-22T16:10:26.000-08:00
Should most likely refer to `AccessPathWrite` and look for write nodes.
This also improves the performance of `rankedAccessPath`, since the
set of candidate blocks is now limited to blocks with both a read and a write.
diff --git a/javascript/ql/lib/semmle/javascript/GlobalAccessPaths.qll b/javascript/ql/lib/semmle/javascript/GlobalAccessPaths.qll
@@ -492,7 +492,7 @@ module AccessPath {
      */
     pragma[noinline]
     private predicate hasWrite(ReachableBasicBlock bb) {
-      bb = getAccessTo(_, _, AccessPathRead()).getBasicBlock()
+      bb = getAccessTo(_, _, AccessPathWrite()).getBasicBlock()
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -492,7 +492,7 @@ module AccessPath {`
`492`	`492`	`*/`
`493`	`493`	`pragma[noinline]`
`494`	`494`	`private predicate hasWrite(ReachableBasicBlock bb) {`
`495`		`- bb = getAccessTo(_, _, AccessPathRead()).getBasicBlock()`
	`495`	`+ bb = getAccessTo(_, _, AccessPathWrite()).getBasicBlock()`
`496`	`496`	`}`
`497`	`497`
`498`	`498`	`/**`