C++: Also add MSVC-related 'alloca'-like functions.

MathiasVP · MathiasVP · commit bae7e10e463c · 2023-11-15T12:07:17.000Z
diff --git a/cpp/ql/src/Likely Bugs/Memory Management/ReturnStackAllocatedMemory.ql b/cpp/ql/src/Likely Bugs/Memory Management/ReturnStackAllocatedMemory.ql
@@ -44,7 +44,7 @@ class ReturnStackAllocatedMemoryConfig extends MustFlowConfiguration {
       // `source` is an instruction that represents the return value of a
       // function that is known to return stack-allocated memory.
       exists(Call call |
-        call.getTarget().hasGlobalName(["alloca", "strdupa", "strndupa"]) and
+        call.getTarget().hasGlobalName(["alloca", "strdupa", "strndupa", "_alloca", "_malloca"]) and
         source.getUnconvertedResultExpression() = call
       )
     )

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ class ReturnStackAllocatedMemoryConfig extends MustFlowConfiguration {`
`44`	`44`	// `source` is an instruction that represents the return value of a
`45`	`45`	`// function that is known to return stack-allocated memory.`
`46`	`46`	`exists(Call call \|`
`47`		`- call.getTarget().hasGlobalName(["alloca", "strdupa", "strndupa"]) and`
	`47`	`+ call.getTarget().hasGlobalName(["alloca", "strdupa", "strndupa", "_alloca", "_malloca"]) and`
`48`	`48`	`source.getUnconvertedResultExpression() = call`
`49`	`49`	`)`
`50`	`50`	`)`