Revert "[common-go] backoff and retry watching files"

This reverts commit e43e0d8.

Author: kylos101

components/common-go/watch/file.go

@@ -12,7 +12,6 @@ import (
 	"io"
 	"os"
 	"path/filepath"
-	"time"
 
 	"github.com/fsnotify/fsnotify"
 
@@ -60,12 +59,6 @@ func File(ctx context.Context, path string, onChange func()) error {
 	fw.hash = hash
 
 	go func() {
-		const (
-			initialBackoff = 100 * time.Millisecond
-			maxBackoff     = 15 * time.Second
-		)
-		var currentBackoff time.Duration
-
 		defer func() {
 			if err != nil {
 				log.WithError(err).Error("Stopping file watch")
@@ -90,40 +83,23 @@ func File(ctx context.Context, path string, onChange func()) error {
 					continue
 				}
 
-				currentHash, hashErr := hashConfig(path)
-				if hashErr != nil {
-					log.WithError(hashErr).WithField("event", event.Name).Warn("Cannot check if config has changed, backing off")
-
-					if currentBackoff == 0 {
-						currentBackoff = initialBackoff
-					} else {
-						currentBackoff *= 2
-						if currentBackoff > maxBackoff {
-							currentBackoff = maxBackoff
-						}
-					}
-
-					select {
-					case <-time.After(currentBackoff):
-					case <-ctx.Done():
-						log.Info("Context cancelled during backoff sleep, stopping file watcher")
-						return
-					}
-					continue
+				currentHash, err := hashConfig(path)
+				if err != nil {
+					log.WithError(err).WithField("event", event.Name).Warn("Cannot check if config has changed")
+					return
 				}
 
-				currentBackoff = 0
-
+				// no change
 				if currentHash == fw.hash {
-					log.WithField("path", path).Debug("Config file changed but content hash is the same")
 					continue
 				}
 
 				log.WithField("path", path).Info("reloading file after change")
+
 				fw.hash = currentHash
 				fw.onChange()
-			case watchErr := <-watcher.Errors:
-				log.WithError(watchErr).Error("Unexpected error watching event")
+			case err := <-watcher.Errors:
+				log.WithError(err).Error("Unexpected error watching event")
 			case <-ctx.Done():
 				return
 			}