Various Twig fixes (#19480)

* Use "config()" function call; "config" variable does not exists
* Fix missing lang and title on redirect page
* nullField do not have label, field name, id, ...
* All users fields should be available to prevent issues

Author: trasher

src/Glpi/Controller/IndexController.php

@@ -103,7 +103,9 @@ public function __invoke(Request $request): Response
         if (count($errors) > 0) {
             return $this->render('pages/login_error.html.twig', [
                 'errors'    => $errors,
+                'title'     => __('Access denied'),
                 'login_url' => $CFG_GLPI["root_doc"] . '/front/logout.php?noAUTO=1&redirect=' . \rawurlencode($redirect),
+                'lang'      => $CFG_GLPI["languages"][$_SESSION['glpilanguage']][3]
             ]);
         }
 

src/User.php

@@ -1907,24 +1907,20 @@ protected function computeFriendlyName()
     public function getInfoCard(): string
     {
         $user_params = [
-            'id'                  => $this->getID(),
             'user_name'           => $this->getName(),
-            'email'               => UserEmail::getDefaultForUser($this->getID()),
-            'phone'               => $this->fields["phone"],
-            'phone2'              => $this->fields["phone2"],
-            'mobile'              => $this->fields["mobile"],
-            'locations_id'        => $this->fields['locations_id'],
-            'usertitles_id'       => $this->fields['usertitles_id'],
-            'usercategories_id'   => $this->fields['usercategories_id'],
-            'registration_number' => $this->fields['registration_number'],
+            'email'               => UserEmail::getDefaultForUser($this->getID())
         ];
 
+        foreach ($this->fields as $key => $value) {
+            if (!isset($user_params[$key])) {
+                $user_params[$key] = $value;
+            }
+        }
+
         if (Session::haveRight('user', READ)) {
              $user_params['login'] = $this->fields['name'];
         }
-        if (!empty($this->fields["groups_id"])) {
-            $user_params['groups_id'] = $this->fields["groups_id"];
-        }
+
         return TemplateRenderer::getInstance()->render('components/user/info_card.html.twig', [
             'user'                 => $user_params,
             'enable_anonymization' => Session::getCurrentInterface() == 'helpdesk',

templates/components/form/fields_macros.html.twig

@@ -826,9 +826,9 @@
    {% set options = {'is_horizontal': true}|merge(options) %}
 
    {% if options.is_horizontal %}
-      {{ _self.horizontalField(label, field, id, add_field_html, options) }}
+      {{ _self.horizontalField(null, null, null, null, options) }}
    {% else %}
-      {{ _self.verticalField(label, field, id, add_field_html, options) }}
+      {{ _self.verticalField(null, null, null, null, options) }}
    {% endif %}
 {% endmacro %}
 

templates/components/itilobject/timeline/simple_form.html.twig

@@ -44,7 +44,7 @@
 } %}
 
 {% if show_form %}
-<form method="post" action="{{ target }}" {{ formoptions }} enctype="multipart/form-data" data-submit-once>
+<form method="post" action="{{ target }}" {{ formoptions ?? '' }} enctype="multipart/form-data" data-submit-once>
 {% endif %}
    <div class="row flex-column">
       {% if not item.isNewItem() %}

templates/pages/setup/notification/ajax_setting.html.twig

@@ -34,7 +34,7 @@
 {% import 'components/form/fields_macros.html.twig' as fields %}
 
 {% block form_fields %}
-    {{ fields.dropdownArrayField('notifications_ajax_sound', config['notifications_ajax_sound'], {
+    {{ fields.dropdownArrayField('notifications_ajax_sound', config('notifications_ajax_sound'), {
         sound_a: __('Sound') ~ ' A',
         sound_b: __('Sound') ~ ' B',
         sound_c: __('Sound') ~ ' C',
@@ -44,19 +44,19 @@
         emptylabel: __('Disabled'),
     }) }}
 
-    {{ fields.dropdownNumberField('notifications_ajax_check_interval', config['notifications_ajax_check_interval'], __('Time to check for new notifications (in seconds)'), {
+    {{ fields.dropdownNumberField('notifications_ajax_check_interval', config('notifications_ajax_check_interval'), __('Time to check for new notifications (in seconds)'), {
         min: 5,
         max: 120,
         step: 5
     }) }}
 
-    {{ fields.textField('notifications_ajax_icon_url', config['notifications_ajax_icon_url'], __('URL of the icon'), {
+    {{ fields.textField('notifications_ajax_icon_url', config('notifications_ajax_icon_url'), __('URL of the icon'), {
         additional_attributes: {
             placeholder: path('pics/glpi.png')
         }
     }) }}
 
-    {{ fields.dropdownNumberField('notifications_ajax_expiration_delay', config['notifications_ajax_expiration_delay'], __('Validity period of notifications (in days)'), {
+    {{ fields.dropdownNumberField('notifications_ajax_expiration_delay', config('notifications_ajax_expiration_delay'), __('Validity period of notifications (in days)'), {
         helper: __('Notifications older than the selected value will not be displayed. Expired notifications will be deleted by the %s crontask.')|format(stale_crontask_name),
         toadd: {
             0: __('Unlimited')