Skip to content

Commit 6458984

Browse files
committed
fix outdated tests
1 parent e3d4a72 commit 6458984

File tree

5 files changed

+28
-25
lines changed

5 files changed

+28
-25
lines changed

.github/workflows/test.yml

+5-5
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@ jobs:
1515
runs-on: ubuntu-latest
1616

1717
steps:
18-
- uses: actions/setup-node@v2
18+
- uses: actions/checkout@v4
19+
20+
- uses: actions/setup-node@v4
1921
with:
2022
node-version: 19
2123

22-
- uses: actions/setup-go@v4
24+
- uses: actions/setup-go@v5
2325
with:
24-
go-version: 1.20.1
25-
26-
- uses: actions/checkout@v3
26+
go-version: 1.21
2727

2828
- run: |
2929
go get -u ./...

.golangci.yml

+7-5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,3 @@
1-
run:
2-
skip-dirs-use-default: false
3-
41
linters:
52
enable-all: true
63
disable:
@@ -22,8 +19,12 @@ linters:
2219
- exhaustruct
2320
- nilnil
2421
- nonamedreturns
22+
- mnd
2523

2624
# Deprecated ones:
25+
- copyloopvar
26+
- intrange
27+
- execinquery
2728
- structcheck
2829
- interfacer
2930
- deadcode
@@ -35,8 +36,9 @@ linters:
3536
- nosnakecase
3637
- scopelint
3738

38-
gocyclo:
39-
min-complexity: 15
39+
linters-settings:
40+
gocyclo:
41+
min-complexity: 15
4042

4143
issues:
4244
exclude-use-default: false

error-handling.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ func main() {
7171
}
7272

7373
func handleError(err error) {
74-
var evalErr *rod.ErrEval
74+
var evalErr *rod.EvalError
7575
if errors.Is(err, context.DeadlineExceeded) { // timeout error
7676
fmt.Println("timeout err")
7777
} else if errors.As(err, &evalErr) { // eval error

go.mod

+7-5
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
11
module github.com/go-rod/go-rod.github.io
22

3-
go 1.17
3+
go 1.21
4+
5+
toolchain go1.22.1
46

57
require (
6-
github.com/go-rod/rod v0.114.2
7-
github.com/ysmood/got v0.34.2
8+
github.com/go-rod/rod v0.116.2
9+
github.com/ysmood/got v0.40.0
810
github.com/ysmood/gson v0.7.3
911
)
1012

1113
require (
1214
github.com/ysmood/fetchup v0.2.3 // indirect
1315
github.com/ysmood/goob v0.4.0 // indirect
14-
github.com/ysmood/gop v0.0.2 // indirect
15-
github.com/ysmood/leakless v0.8.0 // indirect
16+
github.com/ysmood/gop v0.2.0 // indirect
17+
github.com/ysmood/leakless v0.9.0 // indirect
1618
)

go.sum

+8-9
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
1-
github.com/go-rod/rod v0.114.2 h1:Qwt+vZHHnb117zc0q+XjhAJCkB01hchWSxH/raCyLb4=
2-
github.com/go-rod/rod v0.114.2/go.mod h1:aiedSEFg5DwG/fnNbUOTPMTTWX3MRj6vIs/a684Mthw=
1+
github.com/go-rod/rod v0.116.2 h1:A5t2Ky2A+5eD/ZJQr1EfsQSe5rms5Xof/qj296e+ZqA=
2+
github.com/go-rod/rod v0.116.2/go.mod h1:H+CMO9SCNc2TJ2WfrG+pKhITz57uGNYU43qYHh438Mg=
33
github.com/ysmood/fetchup v0.2.3 h1:ulX+SonA0Vma5zUFXtv52Kzip/xe7aj4vqT5AJwQ+ZQ=
44
github.com/ysmood/fetchup v0.2.3/go.mod h1:xhibcRKziSvol0H1/pj33dnKrYyI2ebIvz5cOOkYGns=
55
github.com/ysmood/goob v0.4.0 h1:HsxXhyLBeGzWXnqVKtmT9qM7EuVs/XOgkX7T6r1o1AQ=
66
github.com/ysmood/goob v0.4.0/go.mod h1:u6yx7ZhS4Exf2MwciFr6nIM8knHQIE22lFpWHnfql18=
7-
github.com/ysmood/gop v0.0.2 h1:VuWweTmXK+zedLqYufJdh3PlxDNBOfFHjIZlPT2T5nw=
8-
github.com/ysmood/gop v0.0.2/go.mod h1:rr5z2z27oGEbyB787hpEcx4ab8cCiPnKxn0SUHt6xzk=
9-
github.com/ysmood/got v0.34.1/go.mod h1:yddyjq/PmAf08RMLSwDjPyCvHvYed+WjHnQxpH851LM=
10-
github.com/ysmood/got v0.34.2 h1:oN4DDWwpN5BdNPqYtOIW8a13CsAdzTOECTND7pQQ148=
11-
github.com/ysmood/got v0.34.2/go.mod h1:yddyjq/PmAf08RMLSwDjPyCvHvYed+WjHnQxpH851LM=
7+
github.com/ysmood/gop v0.2.0 h1:+tFrG0TWPxT6p9ZaZs+VY+opCvHU8/3Fk6BaNv6kqKg=
8+
github.com/ysmood/gop v0.2.0/go.mod h1:rr5z2z27oGEbyB787hpEcx4ab8cCiPnKxn0SUHt6xzk=
9+
github.com/ysmood/got v0.40.0 h1:ZQk1B55zIvS7zflRrkGfPDrPG3d7+JOza1ZkNxcc74Q=
10+
github.com/ysmood/got v0.40.0/go.mod h1:W7DdpuX6skL3NszLmAsC5hT7JAhuLZhByVzHTq874Qg=
1211
github.com/ysmood/gotrace v0.6.0 h1:SyI1d4jclswLhg7SWTL6os3L1WOKeNn/ZtzVQF8QmdY=
1312
github.com/ysmood/gotrace v0.6.0/go.mod h1:TzhIG7nHDry5//eYZDYcTzuJLYQIkykJzCRIo4/dzQM=
1413
github.com/ysmood/gson v0.7.3 h1:QFkWbTH8MxyUTKPkVWAENJhxqdBa4lYTQWqZCiLG6kE=
1514
github.com/ysmood/gson v0.7.3/go.mod h1:3Kzs5zDl21g5F/BlLTNcuAGAYLKt2lV5G8D1zF3RNmg=
16-
github.com/ysmood/leakless v0.8.0 h1:BzLrVoiwxikpgEQR0Lk8NyBN5Cit2b1z+u0mgL4ZJak=
17-
github.com/ysmood/leakless v0.8.0/go.mod h1:R8iAXPRaG97QJwqxs74RdwzcRHT1SWCGTNqY8q0JvMQ=
15+
github.com/ysmood/leakless v0.9.0 h1:qxCG5VirSBvmi3uynXFkcnLMzkphdh3xx5FtrORwDCU=
16+
github.com/ysmood/leakless v0.9.0/go.mod h1:R8iAXPRaG97QJwqxs74RdwzcRHT1SWCGTNqY8q0JvMQ=

0 commit comments

Comments
 (0)