Merge branch 'master' into astolfo-feature/builtin-vector

added the note for further investigation

Author: RealAstolfo

godot-core/src/builtin/math.rs

@@ -43,13 +43,11 @@ pub fn snapped(mut value: f32, step: f32) -> f32 {
 
 pub fn sign(value: f32) -> f32 {
     if value == 0.0 {
-	0.0
+        0.0
+    } else if value < 0.0 {
+        -1.0
     } else {
-	if value < 0.0 {
-	    -1.0
-	} else {
-	    1.0
-	}
+        1.0
     }
 }
 

godot-core/src/builtin/vector2.rs

@@ -209,18 +209,18 @@ impl Vector2 {
 
     pub fn max_axis_index(self) -> Vector2Axis {
         if self.x < self.y {
-	    Vector2Axis::Y
-	} else {
-	    Vector2Axis::X
-	}
+            Vector2Axis::Y
+        } else {
+            Vector2Axis::X
+        }
     }
 
     pub fn min_axis_index(self) -> Vector2Axis {
         if self.x < self.y {
-	    Vector2Axis::X
-	} else {
-	    Vector2Axis::Y
-	}
+            Vector2Axis::X
+        } else {
+            Vector2Axis::Y
+        }
     }
 
     pub fn move_toward(self, to: Self, delta: f32) -> Self {
@@ -258,9 +258,11 @@ impl Vector2 {
     }
 
     pub fn sign(self) -> Self {
-        Self::new(sign(self.x),sign(self.y))
+        Self::new(sign(self.x), sign(self.y))
     }
 
+    // TODO compare with gdnative implementation:
+    // https://github.com/godot-rust/gdnative/blob/master/gdnative-core/src/core_types/vector3.rs#L335-L343
     pub fn slerp(self, to: Self, weight: f32) -> Self {
         let start_length_sq = self.length_squared();
         let end_length_sq = to.length_squared();

godot-core/src/builtin/vector3.rs

@@ -211,35 +211,31 @@ impl Vector3 {
     }
 
     pub fn max_axis_index(self) -> Vector3Axis {
-	if self.x < y {
-	    if self.y < self.z {
-		Vector3Axis::Z
-	    } else {
-		Vector3Axis::Y
-	    }
-	} else {
-	    if self.x < self.z {
-		Vector3Axis::Z
-	    } else {
-		Vector3Axis::X
-	    }
-	}
+        if self.x < self.y {
+            if self.y < self.z {
+                Vector3Axis::Z
+            } else {
+                Vector3Axis::Y
+            }
+        } else if self.x < self.z {
+            Vector3Axis::Z
+        } else {
+            Vector3Axis::X
+        }
     }
 
     pub fn min_axis_index(self) -> Vector3Axis {
-	if self.x < self.y {
-	    if self.x < self.z {
-		Vector3Axis::X
-	    } else {
-		Vector3Axis::Z
-	    }
-	} else {
-	    if self.y < self.z {
-		Vector3Axis::Y
-	    } else {
-		Vector3Axis::Z
-	    }
-	}
+        if self.x < self.y {
+            if self.x < self.z {
+                Vector3Axis::X
+            } else {
+                Vector3Axis::Z
+            }
+        } else if self.y < self.z {
+            Vector3Axis::Y
+        } else {
+            Vector3Axis::Z
+        }
     }
 
     pub fn move_toward(self, to: Self, delta: f32) -> Self {
@@ -281,7 +277,7 @@ impl Vector3 {
     }
 
     pub fn sign(self) -> Self {
-        Self::new(sign(self.x),sign(self.y),sign(self.z))
+        Self::new(sign(self.x), sign(self.y), sign(self.z))
     }
 
     pub fn signed_angle_to(self, to: Self, axis: Self) -> f32 {