Clippy fixes related to inline strings in println!, write!, format! etc.

Author: Bromeon

godot-core/src/builtin/arrays.rs

@@ -288,9 +288,7 @@ impl Array {
         let len = self.len();
         assert!(
             index <= len,
-            "Array insertion index {} is out of bounds: length is {}",
-            index,
-            len
+            "Array insertion index {index} is out of bounds: length is {len}",
         );
         self.as_inner().insert(to_i64(index), value);
     }
@@ -358,9 +356,7 @@ impl Array {
         let len = self.len();
         assert!(
             index < len,
-            "Array index {} is out of bounds: length is {}",
-            index,
-            len
+            "Array index {index} is out of bounds: length is {len}",
         );
     }
 

godot-core/src/builtin/variant/mod.rs

@@ -200,14 +200,14 @@ impl PartialEq for Variant {
 impl fmt::Display for Variant {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         let s = self.stringify();
-        write!(f, "{}", s)
+        write!(f, "{s}")
     }
 }
 
 impl fmt::Debug for Variant {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         // TODO include variant type name
         let s = self.stringify();
-        write!(f, "Variant({})", s)
+        write!(f, "Variant({s})")
     }
 }

godot-core/src/init/mod.rs

@@ -201,7 +201,7 @@ impl InitLevel {
             sys::GDEXTENSION_INITIALIZATION_SCENE => Self::Scene,
             sys::GDEXTENSION_INITIALIZATION_EDITOR => Self::Editor,
             _ => {
-                eprintln!("WARNING: unknown initialization level {}", level);
+                eprintln!("WARNING: unknown initialization level {level}");
                 Self::Scene
             }
         }

godot-core/src/lib.rs

@@ -78,9 +78,9 @@ pub mod private {
 
     pub fn print_panic(err: Box<dyn std::any::Any + Send>) {
         if let Some(s) = err.downcast_ref::<&'static str>() {
-            log::godot_error!("rust-panic:  {}", s);
+            log::godot_error!("rust-panic:  {s}");
         } else if let Some(s) = err.downcast_ref::<String>() {
-            log::godot_error!("rust-panic:  {}", s);
+            log::godot_error!("rust-panic:  {s}");
         } else {
             log::godot_error!("rust-panic of type ID {:?}", err.type_id());
         }

godot-ffi/build.rs

@@ -23,7 +23,7 @@ fn main() {
 
 fn run_bindgen(out_file: &Path) {
     let header_path = "../godot-codegen/input/gdextension_interface.h";
-    println!("cargo:rerun-if-changed={}", header_path);
+    println!("cargo:rerun-if-changed={header_path}");
 
     let builder = bindgen::Builder::default()
         .header(header_path)
@@ -92,7 +92,7 @@ fn apple_include_path() -> Result<String, std::io::Error> {
         .trim_end();
 
     let suffix = "usr/include";
-    let directory = format!("{}/{}", prefix, suffix);
+    let directory = format!("{prefix}/{suffix}");
 
     Ok(directory)
 }

godot-macros/src/derive_godot_class.rs

@@ -255,15 +255,12 @@ impl ExportedField {
                 Ok(value)
             } else {
                 bail(
-                    format!(
-                        "#[export] attribute {} with a non-literal variant_type",
-                        key
-                    ),
+                    format!("#[export] attribute {key} with a non-literal variant_type",),
                     attr,
                 )?
             }
         } else {
-            bail(format!("#[export] attribute without a {}", key), attr)
+            bail(format!("#[export] attribute without a {key}"), attr)
         }
     }
 }

godot-macros/src/godot_api.rs

@@ -270,7 +270,7 @@ fn transform_trait_impl(original_impl: Impl) -> Result<TokenStream, Error> {
             // Unknown methods which are declared inside trait impl are not supported (possibly compiler catches those first anyway)
             other_name => {
                 return bail(
-                    format!("Unsupported GodotExt method: {}", other_name),
+                    format!("Unsupported GodotExt method: {other_name}"),
                     &method.name,
                 )
             }

godot-macros/src/itest.rs

@@ -30,8 +30,8 @@ pub fn transform(input: TokenStream) -> Result<TokenStream, Error> {
     }
 
     let test_name = &func.name;
-    let init_msg = format!("   -- {}", test_name);
-    let error_msg = format!("   !! Test {} failed", test_name);
+    let init_msg = format!("   -- {test_name}");
+    let error_msg = format!("   !! Test {test_name} failed");
     let body = &func.body;
 
     Ok(quote! {