Skip to content

Commit bcad368

Browse files
committed
Elevate clippy::suspicious and warnings (both default warn) to deny level
1 parent 6b44f16 commit bcad368

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

.github/workflows/full-ci.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ on:
1414
- trying
1515

1616
env:
17-
GDEXT_FEATURES: 'godot-core/convenience'
17+
GDEXT_FEATURES: '--features godot-core/convenience'
1818
# GDEXT_CRATE_ARGS: '-p godot-codegen -p godot-ffi -p godot-core -p godot-macros -p godot'
1919

2020
defaults:
@@ -59,8 +59,9 @@ jobs:
5959
binary-filename: godot.linuxbsd.editor.dev.x86_64
6060

6161
- name: "Check clippy"
62-
run: cargo clippy -- -D clippy::style -D clippy::complexity -D clippy::perf -D clippy::dbg_macro -D clippy::todo -D clippy::unimplemented
63-
62+
run: |
63+
cargo clippy --all-targets $GDEXT_FEATURES -- -D clippy::suspicious -D clippy::style -D clippy::complexity -D clippy::perf \
64+
-D clippy::dbg_macro -D clippy::todo -D clippy::unimplemented -D warnings
6465
6566
unit-test:
6667
name: unit-test (${{ matrix.name }}${{ matrix.rust-special }})

.github/workflows/minimal-ci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ on:
1414
- master
1515

1616
env:
17-
GDEXT_FEATURES: 'godot-core/convenience'
17+
GDEXT_FEATURES: '--features godot-core/convenience'
1818
# GDEXT_CRATE_ARGS: '-p godot-codegen -p godot-ffi -p godot-core -p godot-macros -p godot'
1919

2020
defaults:
@@ -59,7 +59,9 @@ jobs:
5959
binary-filename: godot.linuxbsd.editor.dev.x86_64
6060

6161
- name: "Check clippy"
62-
run: cargo clippy -- -D clippy::style -D clippy::complexity -D clippy::perf -D clippy::dbg_macro -D clippy::todo -D clippy::unimplemented
62+
run: |
63+
cargo clippy --all-targets $GDEXT_FEATURES -- -D clippy::suspicious -D clippy::style -D clippy::complexity -D clippy::perf \
64+
-D clippy::dbg_macro -D clippy::todo -D clippy::unimplemented -D warnings
6365
6466
6567
unit-test:

check.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ for arg in "${args[@]}"; do
7676
cmds+=("cargo fmt --all -- --check")
7777
;;
7878
clippy)
79-
cmds+=("cargo clippy $features -- -D clippy::style -D clippy::complexity -D clippy::perf -D clippy::dbg_macro -D clippy::todo -D clippy::unimplemented -D warnings")
79+
cmds+=("cargo clippy $features -- -D clippy::suspicious -D clippy::style -D clippy::complexity -D clippy::perf -D clippy::dbg_macro -D clippy::todo -D clippy::unimplemented -D warnings")
8080
;;
8181
test)
8282
cmds+=("cargo test $features")

0 commit comments

Comments
 (0)