chore: various config updates to CI (#76)

Author: unknwon

.github/workflows/go.yml

@@ -32,17 +32,19 @@ jobs:
         shell: bash
         run: |
           go mod tidy
-          STATUS=$(git status --porcelain go.mod go.sum)
+          STATUS=$(git status --porcelain)
           if [ ! -z "$STATUS" ]; then
-            echo "Running go mod tidy modified go.mod and/or go.sum"
+            echo "Unstaged files:"
+            echo $STATUS
+            echo "Run 'go mod tidy' and commit them"
             exit 1
           fi
 
   test:
     name: Test
     strategy:
       matrix:
-        go-version: [ 1.16.x, 1.17.x, 1.18.x ]
+        go-version: [ 1.13.x, 1.14.x, 1.15.x, 1.16.x, 1.17.x, 1.18.x ]
         platform: [ ubuntu-latest, macos-latest, windows-latest ]
     runs-on: ${{ matrix.platform }}
     steps:

.github/workflows/lsif.yml

@@ -1,18 +1,28 @@
-
 name: LSIF
-on: [push]
+on:
+  push:
+    paths:
+      - '**.go'
+      - 'go.mod'
+      - '.github/workflows/lsif.yml'
+env:
+  GOPROXY: "https://proxy.golang.org"
+
 jobs:
-  build:
+  lsif-go:
+    if: github.repository == 'gogs/git-module'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
       - name: Generate LSIF data
         uses: sourcegraph/lsif-go-action@master
+      - name: Upload LSIF data to sourcegraph.com
+        continue-on-error: true
+        uses: docker://sourcegraph/src-cli:latest
         with:
-          verbose: 'true'
-      - name: Upload LSIF data
-        uses: sourcegraph/lsif-upload-action@master
+          args: lsif upload -github-token=${{ secrets.GITHUB_TOKEN }}
+      - name: Upload LSIF data to cs.unknwon.dev
         continue-on-error: true
+        uses: docker://sourcegraph/src-cli:latest
         with:
-          endpoint: https://sourcegraph.com
-          github_token: ${{ secrets.GITHUB_TOKEN }}
+          args: -endpoint=https://cs.unknwon.dev lsif upload -github-token=${{ secrets.GITHUB_TOKEN }}

.golangci.yml

@@ -0,0 +1,27 @@
+linters-settings:
+  staticcheck:
+    checks: [
+      "all",
+      "-SA1019" # There are valid use cases of strings.Title
+    ]
+  nakedret:
+    max-func-lines: 0 # Disallow any unnamed return statement
+
+linters:
+  enable:
+    - deadcode
+    - errcheck
+    - gosimple
+    - govet
+    - ineffassign
+    - staticcheck
+    - structcheck
+    - typecheck
+    - unused
+    - varcheck
+    - nakedret
+    - gofmt
+    - rowserrcheck
+    - unconvert
+    - goimports
+    - unparam

README.md

@@ -9,7 +9,7 @@ Package git-module is a Go module for Git access through shell commands.
 
 ## Requirements
 
-- Go version must be at least **1.9**.
+- Go version must be at least **1.13**.
 - Git version must be no less than **1.8.3**.
 - For Windows users, try to use the latest version of both.
 

codecov.yml

@@ -4,6 +4,11 @@ coverage:
     project:
       default:
         threshold: 1%
+        informational: true
+    patch:
+      defualt:
+        only_pulls: true
+        informational: true
 
 comment:
   layout: 'diff'

commit_submodule.go

@@ -64,7 +64,7 @@ func (c *Commit) Submodules() (Submodules, error) {
 			if len(path) > 0 && len(url) > 0 {
 				mod := &Submodule{
 					Name: path,
-					URL: url,
+					URL:  url,
 				}
 
 				mod.Commit, c.submodulesErr = c.repo.RevParse(c.id.String() + ":" + mod.Name)

repo_tag.go

@@ -91,7 +91,7 @@ func (r *Repository) getTag(timeout time.Duration, id *SHA1) (*Tag, error) {
 		tag.id = id
 		tag.repo = r
 	default:
-		return nil, fmt.Errorf("unsupported tag type: %s", ObjectType(typ))
+		return nil, fmt.Errorf("unsupported tag type: %s", typ)
 	}
 
 	r.cachedTags.Set(id.String(), tag)