You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Evaluating the impact of the changes may require some domain expertise, since the sim integration tests results will slightly change for the 2nd and 3rd tasks here, and it's important to have some experience with the simulations to judge if those changes are OK or not, as well as reevaluate the tests etc. (see https://torax.readthedocs.io/en/latest/contribution_tips.html#contribution-tips)
Perhaps try going ahead with the first task, which should not break any tests and should make a slight speedup for Newton-Raphson cases that can be evaluated.
To set expectations, please be aware we cannot guarantee to iterate on the eventual PR if it looks like the review process will be very time-consuming. Apologies for that but we have limited bandwidth.
The text was updated successfully, but these errors were encountered: