Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize constant transport coefficient model to be any prescribed form #551

Open
jcitrin opened this issue Nov 19, 2024 · 3 comments
Open
Assignees

Comments

@jcitrin
Copy link
Collaborator

jcitrin commented Nov 19, 2024

No description provided.

@demoncoder-crypto
Copy link
Contributor

Is this issue open, i would love to contribute.

@jcitrin
Copy link
Collaborator Author

jcitrin commented Mar 11, 2025

Thanks for offering! Yes, it is open. Some pointers:

  1. The main thing is to change the constant.py RuntimeParams to pydantic input objects corresponding to time varying arrays. Also, chii, chie, and De should always be positive.

  2. A new type which does this (including the validation) is being developed now: torax_pydantic.PositiveTimeVaryingArray , see Move validation of profile conditions to pydantic #817 .

  3. Once this is done, then the transport model is no longer "constant" since the transport coefficients can change over time and radius, depending on the prescribed user inputs. Therefore the name of the model can change to "prescribed.py"

In general I'd wait a little bit until the new release when all the pydantic stuff will be in. There will be more clear examples to learn from. At the moment the config stuff is a a bit in flux.

@demoncoder-crypto
Copy link
Contributor

I will Start on this issue as soon as tomorrow. Thanks @jcitrin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants