Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a switch between L- and H- modes based on the plasma state #673

Open
anteplu opened this issue Jan 22, 2025 · 3 comments
Open

Add a switch between L- and H- modes based on the plasma state #673

anteplu opened this issue Jan 22, 2025 · 3 comments
Assignees

Comments

@anteplu
Copy link
Collaborator

anteplu commented Jan 22, 2025

  • add an option that allows to track the plasma state (via the LH threshold power) and to switch from L- to H- mode and back;
  • the transition time between the modes has to be somehow prescribed.
@jcitrin
Copy link
Collaborator

jcitrin commented Mar 11, 2025

Possible design:

  1. Remove set_pedestal from profile_conditions
  2. Introduce trigger model options in pedestal_model itself
  3. Various options for trigger model
    • Trigger type (e.g. "prescribed" or "martin" or "metal wall")
      • the attribute for the "prescribed" model is a timearray Boolean (like set_pedestal now)
      • For martin or metal_wall is the state-depending scaling
    • dLH , the time window following a transition (True-->False or False-->True) in which the tped, nped, pped, ramps up or down to or from their nominal value
  4. Set appropriate dynamic_runtime_params based on state at beginning of stepper time interval. This will need to be stateful due to dLH
  5. Include a multiplication factor for the trigger in "martin" or "metal wall" for sensitivity tests

It is recommended that a domain expert carry this out due to the various subtleties

@harshtech123
Copy link
Contributor

@jcitrin the design give by you looks good to me can i work on this , thank you !

@jcitrin
Copy link
Collaborator

jcitrin commented Mar 12, 2025

Thank you for your motivation and willingness to contribute.

However, this issue is already assigned and as written we would prefer that a domain expert carry this out since there are some subtleties and considerations to take into account, that would also need dedicated testing where deeper understanding of the simulation time series outputs are important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants