-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PRESCRIBED mode for sources that affect multiple profiles #806
Comments
Thanks for reminding that we should prioritize this. @Nush395 , would you like to take a look? |
I suppose as @Nush395 has done the majority of the recent sources work he might be well placed, but if he's busy I can easily have a crack at it. Just wanted to check how it meshed with other plans, and whether someone's looking into it already. |
This will be much simpler to do once we have moved our configs to pydantic (this should be completed start of next week :) ). I believe @tamaranorman is planning to tackle this once this is done. |
I started looking at this but indeed pre and post pydantic it was going to look very different. If you want to contribute this go for it if not it is on the roadmap for the next couple of weeks |
Given that the Pydantic changes mean it's a bit of a moving target I might give it a miss! Happy to have flagged that this is a bug that a user is interested in being fixed :) (Very excited to see the switch to Pydantic generally though, I can see it being a big improvement) |
Fixes #806 PiperOrigin-RevId: 744684193
Fixes #806 PiperOrigin-RevId: 744684193
Fixes #806 PiperOrigin-RevId: 744684193
This mirrors internal issue
b/395854896
.See
torax/torax/sources/source.py
Lines 172 to 175 in 3ea75f5
The text was updated successfully, but these errors were encountered: