Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PRESCRIBED mode for sources that affect multiple profiles #806

Closed
theo-brown opened this issue Mar 7, 2025 · 5 comments · Fixed by #947
Closed

Support PRESCRIBED mode for sources that affect multiple profiles #806

theo-brown opened this issue Mar 7, 2025 · 5 comments · Fixed by #947
Assignees

Comments

@theo-brown
Copy link
Collaborator

theo-brown commented Mar 7, 2025

This mirrors internal issue b/395854896.
See

case runtime_params_lib.Mode.PRESCRIBED.value:
# TODO(b/395854896) add support for sources that affect multiple core
# profiles.
return (dynamic_source_runtime_params.prescribed_values,)

@jcitrin
Copy link
Collaborator

jcitrin commented Mar 7, 2025

Thanks for reminding that we should prioritize this. @Nush395 , would you like to take a look?

@theo-brown
Copy link
Collaborator Author

I suppose as @Nush395 has done the majority of the recent sources work he might be well placed, but if he's busy I can easily have a crack at it. Just wanted to check how it meshed with other plans, and whether someone's looking into it already.

@Nush395
Copy link
Collaborator

Nush395 commented Mar 7, 2025

This will be much simpler to do once we have moved our configs to pydantic (this should be completed start of next week :) ). I believe @tamaranorman is planning to tackle this once this is done.

@tamaranorman
Copy link
Member

I started looking at this but indeed pre and post pydantic it was going to look very different. If you want to contribute this go for it if not it is on the roadmap for the next couple of weeks

@theo-brown
Copy link
Collaborator Author

If you want to contribute this go for it

Given that the Pydantic changes mean it's a bit of a moving target I might give it a miss! Happy to have flagged that this is a bug that a user is interested in being fixed :)

(Very excited to see the switch to Pydantic generally though, I can see it being a big improvement)

copybara-service bot pushed a commit that referenced this issue Apr 7, 2025
copybara-service bot pushed a commit that referenced this issue Apr 7, 2025
copybara-service bot pushed a commit that referenced this issue Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants