Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pydantic warnings if possible wrong units identified when building ToraxConfig #939

Open
jcitrin opened this issue Apr 3, 2025 · 3 comments
Open

Add pydantic warnings if possible wrong units identified when building ToraxConfig #939

jcitrin opened this issue Apr 3, 2025 · 3 comments
Assignees
@jcitrin @Nush395

Comments

@jcitrin
Copy link
Collaborator

jcitrin commented Apr 3, 2025

e.g., confusion between MA and A, W and MW
@demoncoder-crypto
Copy link
Contributor

demoncoder-crypto commented Apr 7, 2025 •
edited
Loading

Can I contribute to this one?

@jcitrin
Copy link
Collaborator Author

jcitrin commented Apr 7, 2025

I think this one may need some specific physics domain knowledge on what the appropriate input ranges are. Furthermore we are changing the API I/O at the moment and the units may change. I will internally assign.

@demoncoder-crypto
Copy link
Contributor

Understood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcitrin jcitrin

@Nush395 Nush395

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcitrin @Nush395 @demoncoder-crypto