Skip to content

Commit 453549c

Browse files
cpovirkGoogle Java Core Libraries
authored and
Google Java Core Libraries
committed
Run a test under more environments.
It hasn't actually used "mocks" in the sense of "things from a mocking framework" since cl/85631779, which (confusingly) appears to have been the CL that _added_ the "mocks" comment (to replace a previous `@GwtIncompatible` comment about `withFallback`, which wasn't available under GWT until then). (Probably the author had switched away from using a mocking framework during development but then forgotten to remove `@GwtIncompatible` afterward.) It looks like I carried that comment over from `withFallback` to `catchingAsync` in cl/86180055, and then I added a corresponding TODO in cl/116759522. None of that seems to have been necessary. RELNOTES=n/a PiperOrigin-RevId: 723210249
1 parent f5fa4ea commit 453549c

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

Diff for: android/guava-tests/test/com/google/common/util/concurrent/FuturesTest.java

-3
Original file line numberDiff line numberDiff line change
@@ -1015,9 +1015,6 @@ public void testCatchingAsync_resultCancelledBeforeFallback() throws Exception {
10151015
assertFalse(primary.wasInterrupted());
10161016
}
10171017

1018-
@J2ktIncompatible
1019-
@GwtIncompatible // mocks
1020-
// TODO(cpovirk): eliminate use of mocks
10211018
public void testCatchingAsync_resultCancelledAfterFallback() throws Exception {
10221019
final SettableFuture<Integer> secondary = SettableFuture.create();
10231020
final RuntimeException raisedException = new RuntimeException();

Diff for: guava-tests/test/com/google/common/util/concurrent/FuturesTest.java

-3
Original file line numberDiff line numberDiff line change
@@ -1015,9 +1015,6 @@ public void testCatchingAsync_resultCancelledBeforeFallback() throws Exception {
10151015
assertFalse(primary.wasInterrupted());
10161016
}
10171017

1018-
@J2ktIncompatible
1019-
@GwtIncompatible // mocks
1020-
// TODO(cpovirk): eliminate use of mocks
10211018
public void testCatchingAsync_resultCancelledAfterFallback() throws Exception {
10221019
final SettableFuture<Integer> secondary = SettableFuture.create();
10231020
final RuntimeException raisedException = new RuntimeException();

0 commit comments

Comments
 (0)