Skip to content

Implement IntoBytes for Option types? #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joshlf opened this issue Nov 4, 2023 · 0 comments
Open

Implement IntoBytes for Option types? #596

joshlf opened this issue Nov 4, 2023 · 0 comments
Labels
blocked-on-rust Blocked on a Rust feature landing or stabilizing

Comments

@joshlf
Copy link
Member

joshlf commented Nov 4, 2023 •
edited
Loading

Similar to #293, we should ensure that it's guaranteed that Option<P> satisfies IntoBytes (where P is a pointer type which is subject to NPO), and emit an IntoBytes impl.

This is blocked on rust-lang/rust#117591, which guarantees that observing the bytes of a None::<P> is sound. It is also blocked on guaranteeing that observing the bytes of a Some::<P> is sound, which is effectively ptr2int.
@joshlf joshlf mentioned this issue Nov 4, 2023
Open
@joshlf joshlf added the blocked-on-rust Blocked on a Rust feature landing or stabilizing label Oct 6, 2024
@joshlf joshlf changed the title Implement AsBytes for Option types? Implement IntoBytes for Option types? Feb 19, 2025
@RalfJung RalfJung mentioned this issue Feb 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked-on-rust Blocked on a Rust feature landing or stabilizing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joshlf