chore: rename function for clarity (OZ H-01)

Signed-off-by: Tomás Migone <[email protected]>

Author: tmigone

packages/subgraph-service/contracts/DisputeManager.sol

@@ -197,7 +197,7 @@ contract DisputeManager is
     }
 
     /// @inheritdoc IDisputeManager
-    function createLegacyDispute(
+    function createAndAcceptLegacyDispute(
         address allocationId,
         address fisherman,
         uint256 tokensSlash,

packages/subgraph-service/contracts/interfaces/IDisputeManager.sol

@@ -457,7 +457,7 @@ interface IDisputeManager {
     function createIndexingDispute(address allocationId, bytes32 poi) external returns (bytes32);
 
     /**
-     * @notice Create a legacy dispute.
+     * @notice Creates and auto-accepts a legacy dispute.
      * This disputes can be created to settle outstanding slashing amounts with an indexer that has been
      * "legacy slashed" during or shortly after the transition period. See {HorizonStakingExtension.legacySlash}
      * for more details.
@@ -482,7 +482,7 @@ interface IDisputeManager {
      * @param tokensRewards The amount of tokens to reward the fisherman
      * @return The dispute id
      */
-    function createLegacyDispute(
+    function createAndAcceptLegacyDispute(
         address allocationId,
         address fisherman,
         uint256 tokensSlash,

packages/subgraph-service/test/disputeManager/DisputeManager.t.sol

@@ -203,7 +203,7 @@ contract DisputeManagerTest is SubgraphServiceSharedTest {
         uint256 staking;
     }
 
-    function _createLegacyDispute(
+    function _createAndAcceptLegacyDispute(
         address _allocationId,
         address _fisherman,
         uint256 _tokensSlash,
@@ -236,7 +236,7 @@ contract DisputeManagerTest is SubgraphServiceSharedTest {
             _fisherman,
             _tokensRewards
         );
-        bytes32 _disputeId = disputeManager.createLegacyDispute(
+        bytes32 _disputeId = disputeManager.createAndAcceptLegacyDispute(
             _allocationId,
             _fisherman,
             _tokensSlash,

packages/subgraph-service/test/disputeManager/disputes/legacy.t.sol

@@ -38,17 +38,17 @@ contract DisputeManagerLegacyDisputeTest is DisputeManagerTest {
         _provision(users.indexer, tokensProvisioned, maxSlashingPercentage, disputePeriod);
 
         resetPrank(users.arbitrator);
-        _createLegacyDispute(allocationID, users.fisherman, tokensSlash, tokensRewards);
+        _createAndAcceptLegacyDispute(allocationID, users.fisherman, tokensSlash, tokensRewards);
     }
 
     function test_LegacyDispute_RevertIf_NotArbitrator() public useIndexer {
         vm.expectRevert(abi.encodeWithSelector(IDisputeManager.DisputeManagerNotArbitrator.selector));
-        disputeManager.createLegacyDispute(allocationID, users.fisherman, 0, 0);
+        disputeManager.createAndAcceptLegacyDispute(allocationID, users.fisherman, 0, 0);
     }
 
     function test_LegacyDispute_RevertIf_AllocationNotFound() public useIndexer {
         resetPrank(users.arbitrator);
         vm.expectRevert(abi.encodeWithSelector(IDisputeManager.DisputeManagerIndexerNotFound.selector, address(0)));
-        disputeManager.createLegacyDispute(address(0), users.fisherman, 0, 0);
+        disputeManager.createAndAcceptLegacyDispute(address(0), users.fisherman, 0, 0);
     }
 }