Merge pull request #590 from sdroege/new-quark-leak

sdroege · web-flow · commit 691941a33ead · 2020-02-13T07:13:25.000+02:00
Don't pass an owned string to g_quark_from_static_string()
diff --git a/src/quark.rs b/src/quark.rs
@@ -13,7 +13,7 @@ pub struct Quark(glib_sys::GQuark);
 
 impl Quark {
     pub fn from_string(s: &str) -> Quark {
-        unsafe { from_glib(glib_sys::g_quark_from_static_string(s.to_glib_full())) }
+        unsafe { from_glib(glib_sys::g_quark_from_string(s.to_glib_none().0)) }
     }
 
     #[allow(clippy::trivially_copy_pass_by_ref)]

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ pub struct Quark(glib_sys::GQuark);`
`13`	`13`
`14`	`14`	`impl Quark {`
`15`	`15`	`pub fn from_string(s: &str) -> Quark {`
`16`		`- unsafe { from_glib(glib_sys::g_quark_from_static_string(s.to_glib_full())) }`
	`16`	`+ unsafe { from_glib(glib_sys::g_quark_from_string(s.to_glib_none().0)) }`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`#[allow(clippy::trivially_copy_pass_by_ref)]`