Skip to content

[Stripe Issuing Balance Topups] Only do a topup if topup_amount >= 5k #10147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garyhtou opened this issue Apr 11, 2025 · 0 comments · Fixed by #10160
Closed

[Stripe Issuing Balance Topups] Only do a topup if topup_amount >= 5k #10147

garyhtou opened this issue Apr 11, 2025 · 0 comments · Fixed by #10160

Comments

@garyhtou
Copy link
Member

Stripe issuing balance topups are creating a lot of noise in our bank statements. Since they already aren't one-to-one with transactions, let's only do a topup when the topup_amount is greater than $5k
@polypixeldev polypixeldev mentioned this issue Apr 13, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Apr 14, 2025
@polypixeldev
Only topup stripe if it will be >=5k (#10160)
99a3a2b 
## Summary of the problem
<!-- Why these changes are being made? What problem does it solve? Link
any related issues to provide more details. -->
There's a lot of noise in bank statements from a lot of small Stripe
topups.

Closes #10147 

## Describe your changes
<!-- Explain your thought process to the solution and provide a quick
summary of the changes. -->
Modifies the topup job to return if the amount is less than 5k. 


<!-- If there are any visual changes, please attach images, videos, or
gifs. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only topup stripe if it will be >=5k hackclub/hcb
1 participant
@garyhtou