BUG/MINOR: remove unnecessary reloads because of error files.

ivanmatmati · oktalz · commit 731d32db52e0 · 2023-02-09T13:59:58.000+01:00
diff --git a/pkg/controller/global.go b/pkg/controller/global.go
@@ -133,6 +133,7 @@ func (c *HAProxyController) defaultsCfg() (reload bool) {
 		}
 	}
 	env.SetDefaults(newDefaults)
+	newDefaults.ErrorFiles = defaults.ErrorFiles
 	updated := deep.Equal(newDefaults, defaults)
 	if len(updated) != 0 {
 		if err = c.haproxy.DefaultsPushConfiguration(*newDefaults); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -133,6 +133,7 @@ func (c *HAProxyController) defaultsCfg() (reload bool) {`
`133`	`133`	`}`
`134`	`134`	`}`
`135`	`135`	`env.SetDefaults(newDefaults)`
	`136`	`+ newDefaults.ErrorFiles = defaults.ErrorFiles`
`136`	`137`	`updated := deep.Equal(newDefaults, defaults)`
`137`	`138`	`if len(updated) != 0 {`
`138`	`139`	`if err = c.haproxy.DefaultsPushConfiguration(*newDefaults); err != nil {`