Skip to content

Commit a19ada4

Browse files
oktalzoktalz
committed
MINOR: add aditional logging on informers
1 parent 496f4e5 commit a19ada4

File tree

3 files changed

+48
-0
lines changed

3 files changed

+48
-0
lines changed

‎pkg/k8s/crs-monitor.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,10 @@ func (k k8s) runCRDefinitionsInformer(eventChan chan GroupKind, stop chan struct
3535

3636
factory := apiextensionsinformers.NewSharedInformerFactoryWithOptions(k.apiExtensionsClient, k.cacheResyncPeriod)
3737
informer := factory.Apiextensions().V1().CustomResourceDefinitions().Informer()
38+
errW := informer.SetWatchErrorHandler(func(r *cache.Reflector, err error) {
39+
go logger.Debug("CRD Definitions informer error: %s", err)
40+
})
41+
logger.Error(errW)
3842
_, err := informer.AddEventHandler(cache.ResourceEventHandlerFuncs{
3943
AddFunc: func(obj interface{}) {
4044
crd := obj.(*apiextensionsv1.CustomResourceDefinition)

‎pkg/k8s/crs.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,10 @@ func (c GlobalCR) GetInformer(eventChan chan SyncDataEvent, factory informers.Sh
6161
eventChan <- SyncDataEvent{SyncType: SyncType(c.GetKind()), Namespace: data.GetNamespace(), Name: data.GetName(), Data: data}
6262
}
6363

64+
errW := informer.SetWatchErrorHandler(func(r *cache.Reflector, err error) {
65+
go logger.Debug("Global CR informer error: %s", err)
66+
})
67+
logger.Error(errW)
6468
_, err := informer.AddEventHandler(cache.ResourceEventHandlerFuncs{
6569
AddFunc: func(obj interface{}) {
6670
sendToChannel(eventChan, obj, store.ADDED)
@@ -97,6 +101,10 @@ func (c DefaultsCR) GetInformer(eventChan chan SyncDataEvent, factory informers.
97101
eventChan <- SyncDataEvent{SyncType: SyncType(c.GetKind()), Namespace: data.GetNamespace(), Name: data.GetName(), Data: data}
98102
}
99103

104+
errW := informer.SetWatchErrorHandler(func(r *cache.Reflector, err error) {
105+
go logger.Debug("Defaults CR informer error: %s", err)
106+
})
107+
logger.Error(errW)
100108
_, err := informer.AddEventHandler(cache.ResourceEventHandlerFuncs{
101109
AddFunc: func(obj interface{}) {
102110
sendToChannel(eventChan, obj, store.ADDED)
@@ -133,6 +141,10 @@ func (c BackendCR) GetInformer(eventChan chan SyncDataEvent, factory informers.S
133141
eventChan <- SyncDataEvent{SyncType: SyncType(c.GetKind()), Namespace: data.GetNamespace(), Name: data.GetName(), Data: data}
134142
}
135143

144+
errW := informer.SetWatchErrorHandler(func(r *cache.Reflector, err error) {
145+
go logger.Debug("Backend CR informer error: %s", err)
146+
})
147+
logger.Error(errW)
136148
_, err := informer.AddEventHandler(cache.ResourceEventHandlerFuncs{
137149
AddFunc: func(obj interface{}) {
138150
sendToChannel(eventChan, obj, store.ADDED)

‎pkg/k8s/informers.go

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ import (
2424

2525
func (k k8s) getNamespaceInfomer(eventChan chan SyncDataEvent, factory informers.SharedInformerFactory) cache.SharedIndexInformer { //nolint:ireturn
2626
informer := factory.Core().V1().Namespaces().Informer()
27+
errW := informer.SetWatchErrorHandler(func(r *cache.Reflector, err error) {
28+
go logger.Debug("Namespace informer error: %s", err)
29+
})
30+
logger.Error(errW)
2731
_, err := informer.AddEventHandler(
2832
cache.ResourceEventHandlerFuncs{
2933
AddFunc: func(obj interface{}) {
@@ -118,6 +122,10 @@ func (k k8s) getNamespaceInfomer(eventChan chan SyncDataEvent, factory informers
118122

119123
func (k k8s) getServiceInformer(eventChan chan SyncDataEvent, factory informers.SharedInformerFactory) cache.SharedIndexInformer { //nolint:ireturn
120124
informer := factory.Core().V1().Services().Informer()
125+
errW := informer.SetWatchErrorHandler(func(r *cache.Reflector, err error) {
126+
go logger.Debug("Service informer error: %s", err)
127+
})
128+
logger.Error(errW)
121129
_, err := informer.AddEventHandler(cache.ResourceEventHandlerFuncs{
122130
AddFunc: func(obj interface{}) {
123131
data, ok := obj.(*corev1.Service)
@@ -244,6 +252,10 @@ func (k k8s) getServiceInformer(eventChan chan SyncDataEvent, factory informers.
244252

245253
func (k k8s) getSecretInformer(eventChan chan SyncDataEvent, factory informers.SharedInformerFactory) cache.SharedIndexInformer { //nolint:ireturn
246254
informer := factory.Core().V1().Secrets().Informer()
255+
errW := informer.SetWatchErrorHandler(func(r *cache.Reflector, err error) {
256+
go logger.Debug("Secret informer error: %s", err)
257+
})
258+
logger.Error(errW)
247259
_, err := informer.AddEventHandler(
248260
cache.ResourceEventHandlerFuncs{
249261
AddFunc: func(obj interface{}) {
@@ -313,6 +325,10 @@ func (k k8s) getSecretInformer(eventChan chan SyncDataEvent, factory informers.S
313325

314326
func (k k8s) getConfigMapInformer(eventChan chan SyncDataEvent, factory informers.SharedInformerFactory) cache.SharedIndexInformer { //nolint:ireturn
315327
informer := factory.Core().V1().ConfigMaps().Informer()
328+
errW := informer.SetWatchErrorHandler(func(r *cache.Reflector, err error) {
329+
go logger.Debug("ConfigMap informer error: %s", err)
330+
})
331+
logger.Error(errW)
316332
_, err := informer.AddEventHandler(
317333
cache.ResourceEventHandlerFuncs{
318334
AddFunc: func(obj interface{}) {
@@ -433,6 +449,10 @@ func (k k8s) getEndpointSliceInformer(eventChan chan SyncDataEvent, factory info
433449

434450
func (k k8s) getEndpointsInformer(eventChan chan SyncDataEvent, factory informers.SharedInformerFactory) cache.SharedIndexInformer { //nolint:ireturn
435451
informer := factory.Core().V1().Endpoints().Informer()
452+
errW := informer.SetWatchErrorHandler(func(r *cache.Reflector, err error) {
453+
go logger.Debug("Endpoints informer error: %s", err)
454+
})
455+
logger.Error(errW)
436456
_, err := informer.AddEventHandler(cache.ResourceEventHandlerFuncs{
437457
AddFunc: func(obj interface{}) {
438458
item, err := k.convertToEndpoints(obj, store.ADDED)
@@ -503,6 +523,10 @@ func (k *k8s) getPodInformer(namespace, podPrefix string, resyncPeriod time.Dura
503523
}
504524

505525
func (k k8s) addIngressClassHandlers(eventChan chan SyncDataEvent, informer cache.SharedIndexInformer) {
526+
errW := informer.SetWatchErrorHandler(func(r *cache.Reflector, err error) {
527+
go logger.Debug("IngressClass informer error: %s", err)
528+
})
529+
logger.Error(errW)
506530
_, err := informer.AddEventHandler(
507531
cache.ResourceEventHandlerFuncs{
508532
AddFunc: func(obj interface{}) {
@@ -541,6 +565,10 @@ func (k k8s) addIngressClassHandlers(eventChan chan SyncDataEvent, informer cach
541565
}
542566

543567
func (k k8s) addIngressHandlers(eventChan chan SyncDataEvent, informer cache.SharedIndexInformer) {
568+
errW := informer.SetWatchErrorHandler(func(r *cache.Reflector, err error) {
569+
go logger.Debug("Ingress informer error: %s", err)
570+
})
571+
logger.Error(errW)
544572
_, err := informer.AddEventHandler(
545573
cache.ResourceEventHandlerFuncs{
546574
AddFunc: func(obj interface{}) {
@@ -579,6 +607,10 @@ func (k k8s) addIngressHandlers(eventChan chan SyncDataEvent, informer cache.Sha
579607
}
580608

581609
func (k k8s) addEndpointSliceHandlers(eventChan chan SyncDataEvent, informer cache.SharedIndexInformer) {
610+
errW := informer.SetWatchErrorHandler(func(r *cache.Reflector, err error) {
611+
go logger.Debug("EndpoitSlice informer error: %s", err)
612+
})
613+
logger.Error(errW)
582614
_, err := informer.AddEventHandler(cache.ResourceEventHandlerFuncs{
583615
AddFunc: func(obj interface{}) {
584616
item, err := k.convertToEndpoints(obj, store.ADDED)

0 commit comments

Comments
 (0)