[Feature Request] Code completion for resource types available

[mattwelke]

I like how I can get code completion for attributes for a resource (by typing the first letter or using ctrl-space), but it would be nice too if I had code completion for when I begin typing resource "<prefix>... to help me type a resource that exists in one of my providers. Preferably, I could then hit tab to choose a name for the resource, then hit tab again to have it fill in every required attribute with placeholder values.

For example, I have the AWS provider (version 3.6) installed. If I type like this, and then hit ctrl-space:

I get help that is okay, because it can reference strings from my project, but nothing smart from the providers. I'd like if it suggested things like aws_ami or aws_instance.

[radeksimko]

I will just clarify here, that in VS Code specifically it is possible to have labels, such as aws_instance in resource block, completed automatically, if you choose to also complete the block itself.

This is done by automatically triggering the completion from the server side. However there is no general support for such mechanism (yet) in LSP and most clients will probably prevent on-type completion within double quotes, because they (reasonably) assume it's just arbitrary literal string.

What does not work at this point - and that is the reason I'd like to still keep this issue open - is when you type the above all by hand:

[mattwelke]

Ohh interesting. I can see now that people all have slightly different ways of coding and where they expect to leverage code completion features. For me, I usually type something out in full if I remember it (I can easily remember resource ") and then try to activate code completion when I get to a point where I don't remember stuff (I can't easily remember every possibly Terraform resource given the providers I have installed, especially as I'm learning Terraform). My technique prevents the code completion from being triggered properly.

[radeksimko]

Just to be clear I wasn't suggesting this is common or correct technique, just a technique that works within the limitations of the LSP.

This is one of the relevant upstream issues discussing the problem: microsoft/language-server-protocol#565 and this is where the current workaround was implemented: #300

[mattwelke]

Understood. I was just doing a brain dump in case it helps the DX folks who end up addressing this.

[radeksimko]

In the interest of tracking a feature in one place I'm going to close this in favour of the following issues:

• textDocument/complete: Provide completion in incomplete blocks #57
• feat: required arguments pre-filled when creating resource #96
• Investigate quick suggestions inside quotes vscode-terraform#397

Thank you for understanding.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.