Issue justinethier#203 - rational? now handles floats properly

Author: justinethier

ChangeLog.markdown

@@ -1,3 +1,10 @@
+v3.19.2
+--------
+
+Bug Fixes:
+
+- Fixed `rational?` to properly handle floating-point numbers.
+
 v3.19.1
 --------
 

hs-src/Language/Scheme/Numerical.hs

@@ -613,8 +613,7 @@ isReal _ = return $ Bool False
 isRational :: [LispVal] -> ThrowsError LispVal
 isRational ([Number _]) = return $ Bool True
 isRational ([Rational _]) = return $ Bool True
-isRational ([n@(Float _)]) = return $ Bool $ isFloatAnInteger n
-                             -- FUTURE: not quite good enough, could be represented exactly and not an integer
+isRational ([Float n]) = return $ Bool $ not $ isInfinite n 
 isRational _ = return $ Bool False
 
 -- |Predicate to determine if given number is an integer.

husk-scheme.cabal

@@ -1,5 +1,5 @@
 Name:                husk-scheme
-Version:             3.19.1
+Version:             3.19.2
 Synopsis:            R5RS Scheme interpreter, compiler, and library.
 Description:         
   <<https://github.com/justinethier/husk-scheme/raw/master/docs/husk-scheme.png>>

tests/t-numerical-ops.scm

@@ -15,7 +15,7 @@
 (assert/equal (real? -2.5+0.1i) #f)
 ;(assert/equal (real? -2.5+0.0i) #f)
 ;Issue #14: (assert/equal (real? #e1e103) #t)
-; TODO: (assert/equal (rational? 3.5) #t)
+(assert/equal (rational? 3.5) #t)
 (assert/equal (rational? 6/10) #t)
 (assert/equal (rational? 6/3) #t)
 (assert/equal (integer? 3+0i) #t)