Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support valueFromEnv for jwkFromUrl & issuer field in auth-config.yaml file #10681

Open
sanchitdikshit opened this issue Feb 13, 2025 · 1 comment
Labels
k/enhancement New feature or improve an existing feature support/escalation

Comments

@sanchitdikshit
Copy link

sanchitdikshit commented Feb 13, 2025

Component

Graphql Engine (for features that relates to graphql features; metadata modeling) -> c/v3-engine

Is your proposal related to a problem?

jwkFromUrl & issuer field currently do not support valueFromEnv and it only supports the string values in auth-config.yaml file.

Describe the solution you'd like

Ability to use valueFromEnv instead of the hardcoded String

Describe alternatives you've considered

The current workaround is to use separate Supergraphs.

@sanchitdikshit sanchitdikshit added the k/enhancement New feature or improve an existing feature label Feb 13, 2025
@ashishtilara
Copy link

One more request related to this is the documentation on encoding the values and examples for other attributes. for example, I have following setup that works but notice ~1 in path at some places to replace /, without that the parsing doesn't work.

kind: AuthConfig
version: v2
definition:
  mode:
    jwt:
      claimsConfig:
        locations:
          x-hasura-default-role:
            path:
              path: /https:~1~1example.com~1user/context
          x-hasura-allowed-roles:
            literal:
              - ADMIN
              - USER
          x-hasura-user-id:
            path:
              path: /https:~1~1lynksupplychain.com~1user/user_id
              default: null
      tokenLocation:
        type: BearerAuthorization
      key:
        jwkFromUrl: https://auth.example.com/.well-known/jwks.json
      audience:
        - https://api.example.com
      issuer: https://auth.example.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k/enhancement New feature or improve an existing feature support/escalation
Projects
None yet
Development

No branches or pull requests

2 participants