Make "builtinLinters": "all" mean all linters, but... (#450)

* Add UnreachableCodeLinter to `'default'` and `'all' `

* Fix lint errors caught by UnreachableCodeLinter

* Add PreferLambdasLinter and NoEmptyStatementsLinter to `all`
In hhast `'all'` doesn't really mean `all`. Let's fix that.
FinalOrAbstractClass and DataProviderTypesLinter are missing.
I will add FinalOrAbstractClass in the next commit.

* Add FinalOrAbstractClassLinter to `'all'`

* Update codegen

* Update codegen (again)

* $v could not be inferred on hhvm-nightly

Author: lexidor

codegen/inferred_relationships.hack

@@ -13,6 +13,7 @@ use type Facebook\HHAST\Node;
 use function Facebook\HHAST\find_position;
 use namespace HH\Lib\Str;
 
+// HHAST_IGNORE_ERROR[FinalOrAbstractClass] This class is meant to be extended.
 class ASTLintError extends SingleRuleLintError {
   <<__Override>>
   public function __construct(

codegen/syntax/ModuleMembershipDeclaration.hack

@@ -11,6 +11,8 @@ namespace Facebook\HHAST;
 
 use namespace HH\Lib\Str;
 
+// HHAST_IGNORE_ERROR[FinalOrAbstractClass] This class declares a protected method
+// splitName(), which may be overridden in a child class.
 class AsyncFunctionAndMethodLinter extends FunctionNamingLinter {
   const type TConfig = shape();
 

codegen/token_from_data.hack

@@ -9,6 +9,7 @@
 
 namespace Facebook\HHAST;
 
+// HHAST_IGNORE_ERROR[FinalOrAbstractClass] This class may be extended elsewhere
 class BuiltLintError extends SingleRuleLintError {
   private ?(int, int) $position = null;
 

src/Linters/ASTLintError.hack

@@ -12,6 +12,8 @@ namespace Facebook\HHAST;
 use type Facebook\HHAST\{FunctionDeclaration, MethodishDeclaration};
 use namespace HH\Lib\{C, Str};
 
+// HHAST_IGNORE_ERROR[FinalOrAbstractClass] This class declares a protected method
+// splitName(), which may be overridden in a child class.
 class CamelCasedMethodsUnderscoredFunctionsLinter extends FunctionNamingLinter {
   const type TConfig = shape();
 

src/Linters/AsyncFunctionAndMethodLinter.hack

@@ -9,6 +9,7 @@
 
 namespace Facebook\HHAST;
 
+// HHAST_IGNORE_ERROR[FinalOrAbstractClass] This class is meant to be extended.
 class LineLintError extends SingleRuleLintError {
 
   public function __construct(

src/Linters/BuiltLintError.hack

@@ -11,7 +11,7 @@ namespace Facebook\HHAST;
 
 use namespace HH\Lib\{Str, Vec};
 
-class MustUseBracesForControlFlowLinter extends AutoFixingASTLinter {
+final class MustUseBracesForControlFlowLinter extends AutoFixingASTLinter {
   const type TConfig = shape();
   const type TNode = IControlFlowStatement;
   const type TContext = Script;

src/Linters/CamelCasedMethodsUnderscoredFunctionsLinter.hack

@@ -11,7 +11,7 @@ namespace Facebook\HHAST;
 
 use namespace HH\Lib\{C, Vec};
 
-class NoNewlineAtStartOfControlFlowBlockLinter extends AutoFixingASTLinter {
+final class NoNewlineAtStartOfControlFlowBlockLinter extends AutoFixingASTLinter {
   const type TConfig = shape();
   const type TNode = IControlFlowStatement;
   const type TContext = Script;

src/Linters/LineLintError.hack

@@ -11,6 +11,7 @@ namespace Facebook\HHAST;
 
 use type Facebook\HHAST\File;
 
+// HHAST_IGNORE_ERROR[FinalOrAbstractClass] This class is meant to be extended.
 /**
  * A problem detected by a SingleRuleLinter
  */

src/Linters/MustUseBracesForControlFlowLinter.hack

@@ -11,7 +11,7 @@ namespace Facebook\HHAST;
 
 use namespace HH\Lib\Str;
 
-class StrictModeOnlyLinter extends AutoFixingASTLinter {
+final class StrictModeOnlyLinter extends AutoFixingASTLinter {
   const type TConfig = shape();
   const type TNode = MarkupSuffix;
   const type TContext = Script;

src/Linters/NoNewlineAtStartOfControlFlowBlockLinter.hack

@@ -74,8 +74,6 @@ final class ImplicitShapeSubtypesMigration extends StepBasedMigration {
           ->getTrailing(),
       ),
     );
-
-    return $shape;
   }
 
   <<__Override>>

src/Linters/SingleRuleLintError.hack

@@ -9,7 +9,7 @@
 
 namespace Facebook\HHAST\__Private;
 
-class AsyncQueue {
+final class AsyncQueue {
   private ?Awaitable<mixed> $queue;
 
   public async function enqueueAndWaitForAsync<T>(

src/Linters/StrictModeOnlyLinter.hack

@@ -11,7 +11,7 @@ namespace Facebook\HHAST\__Private\LSPLib;
 
 use namespace Facebook\HHAST\__Private\LSP;
 
-class ApplyWorkspaceEditCommand extends ClientCommand {
+final class ApplyWorkspaceEditCommand extends ClientCommand {
   const string METHOD = 'workspace/applyEdit';
   const type TParams = LSP\ApplyWorkspaceEditParams;
 }