Skip to content

Commit 3f7a4c7

Browse files
committed
Use "additionalOptions" to skip Jacoco in Jenkinsfile
1 parent fab6a1c commit 3f7a4c7

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

Jenkinsfile

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,13 @@ stage('Configure') {
4646
// We want to enable preview features when testing newer builds of OpenJDK:
4747
// even if we don't use these features, just enabling them can cause side effects
4848
// and it's useful to test that.
49-
new BuildEnvironment( testJdkVersion: '23', testJdkLauncherArgs: '--enable-preview', skipJacoco: true ),
50-
new BuildEnvironment( testJdkVersion: '24', testJdkLauncherArgs: '--enable-preview', skipJacoco: true ),
49+
new BuildEnvironment( testJdkVersion: '23', testJdkLauncherArgs: '--enable-preview', additionalOptions: '-PskipJacoco=true' ),
50+
new BuildEnvironment( testJdkVersion: '24', testJdkLauncherArgs: '--enable-preview', additionalOptions: '-PskipJacoco=true' ),
5151
// The following JDKs aren't supported by Hibernate ORM out-of-the box yet:
5252
// they require the use of -Dnet.bytebuddy.experimental=true.
5353
// Make sure to remove that argument as soon as possible
5454
// -- generally that requires upgrading bytebuddy after the JDK goes GA.
55-
new BuildEnvironment( testJdkVersion: '25', testJdkLauncherArgs: '--enable-preview -Dnet.bytebuddy.experimental=true', skipJacoco: true ),
55+
new BuildEnvironment( testJdkVersion: '25', testJdkLauncherArgs: '--enable-preview -Dnet.bytebuddy.experimental=true', additionalOptions: '-PskipJacoco=true' ),
5656
];
5757

5858
if ( env.CHANGE_ID ) {
@@ -143,10 +143,6 @@ stage('Build') {
143143
state[buildEnv.tag]['additionalOptions'] = state[buildEnv.tag]['additionalOptions'] +
144144
" -Pci.node=${buildEnv.node}"
145145
}
146-
if ( buildEnv.skipJacoco ) {
147-
state[buildEnv.tag]['additionalOptions'] = state[buildEnv.tag]['additionalOptions'] +
148-
" -PskipJacoco=true"
149-
}
150146
state[buildEnv.tag]['containerName'] = null;
151147
stage('Checkout') {
152148
checkout scm
@@ -233,7 +229,6 @@ class BuildEnvironment {
233229
String additionalOptions
234230
String notificationRecipients
235231
boolean longRunning
236-
boolean skipJacoco
237232

238233
String toString() { getTag() }
239234
String getTag() { "${node ? node + "_" : ''}${testJdkVersion ? 'jdk_' + testJdkVersion + '_' : '' }${dbName}" }

0 commit comments

Comments
 (0)