Skip to content

Commit 761b7af

Browse files
committed
[HHH-19365]fix comments and remove unused skip
1 parent 3920d37 commit 761b7af

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

hibernate-core/src/test/java/org/hibernate/orm/test/mapping/basic/XmlMappingTests.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public void tearDown(SessionFactoryScope scope) {
100100
}
101101

102102
@Test
103-
@SkipForDialect(dialectClass = GaussDBDialect.class, reason = "opengauss don't support")
103+
@SkipForDialect(dialectClass = GaussDBDialect.class, reason = "GaussDB don't support this xml feature")
104104
public void verifyMappings(SessionFactoryScope scope) {
105105
final MappingMetamodelImplementor mappingMetamodel = scope.getSessionFactory()
106106
.getRuntimeMetamodels()
@@ -125,7 +125,7 @@ public void verifyMappings(SessionFactoryScope scope) {
125125
}
126126

127127
@Test
128-
@SkipForDialect(dialectClass = GaussDBDialect.class, reason = "opengauss don't support")
128+
@SkipForDialect(dialectClass = GaussDBDialect.class, reason = "GaussDB don't support this xml feature")
129129
public void verifyReadWorks(SessionFactoryScope scope) {
130130
scope.inTransaction(
131131
(session) -> {
@@ -143,7 +143,7 @@ public void verifyReadWorks(SessionFactoryScope scope) {
143143
@SkipForDialect(dialectClass = SybaseDialect.class, matchSubTypes = true, reason = "Sybase doesn't support comparing LOBs with the = operator")
144144
@SkipForDialect(dialectClass = OracleDialect.class, matchSubTypes = true, reason = "Oracle doesn't support comparing JSON with the = operator")
145145
@SkipForDialect(dialectClass = AltibaseDialect.class, reason = "Altibase doesn't support comparing CLOBs with the = operator")
146-
@SkipForDialect(dialectClass = GaussDBDialect.class, reason = "opengauss don't support")
146+
@SkipForDialect(dialectClass = GaussDBDialect.class, reason = "GaussDB doesn't support comparing CLOBs with the = operator")
147147
public void verifyComparisonWorks(SessionFactoryScope scope) {
148148
scope.inTransaction(
149149
(session) -> {

hibernate-core/src/test/java/org/hibernate/orm/test/query/criteria/CriteriaBuilderNonStandardFunctionsTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import jakarta.persistence.criteria.ParameterExpression;
1818
import org.hibernate.dialect.CockroachDialect;
1919
import org.hibernate.community.dialect.DerbyDialect;
20-
import org.hibernate.dialect.GaussDBDialect;
2120
import org.hibernate.dialect.PostgreSQLDialect;
2221
import org.hibernate.query.criteria.HibernateCriteriaBuilder;
2322
import org.hibernate.query.criteria.JpaExpression;
@@ -418,7 +417,6 @@ public void testAtan2(SessionFactoryScope scope) {
418417
}
419418

420419
@Test
421-
@SkipForDialect( dialectClass = GaussDBDialect.class, reason = "type:resolved.Function sinh(double precision) does not exist.")
422420
public void testHyperbolic(SessionFactoryScope scope) {
423421
scope.inTransaction( session -> {
424422
HibernateCriteriaBuilder cb = session.getCriteriaBuilder();

0 commit comments

Comments
 (0)